[PATCH net-next 01/10] net: pcs: xpcs: move PCS reset to .pcs_pre_config()
Serge Semin
fancer.lancer at gmail.com
Wed Oct 2 16:43:32 PDT 2024
On Thu, Oct 03, 2024 at 01:12:58AM GMT, Andrew Lunn wrote:
> > But if my reasoning haven't been persuasive enough anyway, then fine by
> > me. I'll just add a new patch (as described in 2.1y) to my series.
> > But please be ready that it will look as a reversion of the Russell'
> > patches 2.1 and 2.3.
>
> Note what Russell said in patch 0/X:
>
> > First, sorry for the bland series subject - this is the first in a
> > number of cleanup series to the XPCS driver.
>
> I suspect you need to wait until all the series have landed before
> your patches can be applied on top.
Of course I have no intention to needlessly over-complicate the
review/maintenance process by submitting a new series interfering with
the already sent work. That's what I mentioned on the RFC-stage of
this series a few days ago:
https://lore.kernel.org/netdev/mykeabksgikgk6otbub2i3ksfettbozuhqy3gt5vyezmemvttg@cpjn5bcfiwei/
But for the reason that I've already done some improvements too, why
not to use some of them to simplify the Russell' and further changes
if they concern the same functionality?.. That's why I originally
suggested my patch as a pre-requisite change.
Anyway the Russell' patch set in general looks good to me. I have no
more comments other than regarding the soft-reset change I described in
my previous message.
-Serge(y)
>
> Andrew
More information about the linux-arm-kernel
mailing list