[v2 PATCH] iommu/arm-smmu-v3: Fix L1 stream table index calculation for 32-bit sid size

Yang Shi yang at os.amperecomputing.com
Wed Oct 2 12:04:32 PDT 2024



On 10/2/24 11:17 AM, Nicolin Chen wrote:
> I think both v1 and v2 are missing iommu at lists.linux.dev in CC.

Will do it for the later revision.

>
> On Wed, Oct 02, 2024 at 10:55:14AM -0700, Yang Shi wrote:
>> +static inline unsigned int arm_smmu_strtab_max_sid(struct arm_smmu_device *smmu)
>> +{
>> +       return (1ULL << smmu->sid_bits);
>> +}
>> +
> Hmm, why ULL gets truncated to unsigned int here?

No particular reason, but it should be better to not truncate here. Will 
fix it.

>
> Thanks
> Nicolin




More information about the linux-arm-kernel mailing list