[PATCH net-next 06/15] net: sparx5: add constants to match data
Daniel Machon
daniel.machon at microchip.com
Wed Oct 2 06:31:32 PDT 2024
> > +#define SPX5_CONST(const) sparx5->data->consts->const
>
> This is way too ugly too live.
> Please type the code out, there's no prize for having low LoC count.
>
Hi Jakub,
By "type the code out" - are you saying that we should not be using a macro
for accessing the const at all? and rather just:
struct sparx5_consts *consts = sparx5->data->consts;
consts->some_var
or pass in the sparx5 pointer to the macro too, which was the concert that
Jacob raised.
Thanks.
/Daniel
More information about the linux-arm-kernel
mailing list