[PATCH v9 1/6] misc: Add support for LAN966x PCI device

[Krzysztof Kozlowski]

On 29/11/2024 09:10, Herve Codina wrote:
>>> +config MCHP_LAN966X_PCI
>>> +	tristate "Microchip LAN966x PCIe Support"
>>> +	depends on PCI
>>> +	select OF
>>> +	select OF_OVERLAY  
>>
>> Are these "select" statements what we want? When configuring current
>> mainline snapshot, I accidentally enabled this driver and ended up
>> flooded with an enormous amount of new config options, most of which
>> didn't make much sense on x86_64. It took quite long to investigate why.
>>
>> Couldn't we rather use
>>
>> 	depends on PCI && OF && OF_OVERLAY
>>
>> like other drivers?
>>
> 
> I don't have a strong opinion on this 'select' vs 'depends on' for those
> symbols.


You should not select user-visible symbols, with exception of arch
stuff. This is not arch, so you should use dependencies.


Best regards,
Krzysztof