[PATCH v2 07/12] KVM: arm64: Rework specifying restricted features for protected VMs

[Kristina Martšenko]

Hi Fuad,

On 22/11/2024 11:06, Fuad Tabba wrote:
> The existing code didn't properly distinguish between signed and
> unsigned features, and was difficult to read and to maintain.
> Rework it using the same method used in other parts of KVM when
> handling vcpu features.
> 
> Signed-off-by: Fuad Tabba <tabba at google.com>
> ---


> +static const struct pvm_feature pvmid_aa64isar2[] = {
> +	MAX_FEAT_FUNC(ID_AA64ISAR2_EL1, GPA3, IMP, _vcpu_has_ptrauth),
> +	MAX_FEAT_FUNC(ID_AA64ISAR2_EL1, APA3, PAuth, _vcpu_has_ptrauth),
> +	MAX_FEAT(ID_AA64ISAR2_EL1, ATS1A, IMP),
> +	FEAT_END
> +};

Just wondering - did you intentionally hide the MOPS feature from protected
guests here? (It was exposed before)

I did notice that the HCRX trap setting is currently broken/missing in upstream
pKVM, which means MOPS instructions UNDEF in the guest. Is it related to that?

Thanks,
Kristina