[PATCH 2/2] i2c: xiic: Add atomic transfer support
Wolfram Sang
wsa+renesas at sang-engineering.com
Sun Nov 24 07:03:19 PST 2024
> > + while (xiic_rx_space(i2c)) {
> Let's remind what xiic_rx_space is
> #define xiic_rx_space(i2c) ((i2c)->rx_msg->len - (i2c)->rx_pos)
>
> > + if (xiic_getreg32(i2c, XIIC_IISR_OFFSET) & XIIC_INTR_RX_FULL_MASK) {
> > + if (!i2c->rx_msg) {
> This check is suspicious. If i2c->rx_msg is NULL then the while
> above already dereferenced a NULL pointer.
> What is going on?
Valid point. I'll remove the patches from the pull request.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20241124/12ce3d3d/attachment.sig>
More information about the linux-arm-kernel
mailing list