[RESEND PATCH] net: microchip: vcap: Add typegroup table terminators in kunit tests

Daniel Machon daniel.machon at microchip.com
Wed Nov 20 02:52:02 PST 2024


Hi Guenter,

> Comments in the code state that "A typegroup table ends with an all-zero
> terminator". Add the missing terminators.
> 
> Some of the typegroups did have a terminator of ".offset = 0, .width = 0,
> .value = 0,". Replace those terminators with "{ }" (no trailing ',') for
> consistency and to excplicitly state "this is a terminator".
> 
> Fixes: 67d637516fa9 ("net: microchip: sparx5: Adding KUNIT test for the VCAP API")
> Cc: Steen Hegelund <steen.hegelund at microchip.com>
> Signed-off-by: Guenter Roeck <linux at roeck-us.net>
> ---
> resend: forgot to copy netdev at .

You are missing the target tree in the subject - in this case it should be
'net'

Apart from that, I think the fix looks correct. In the drivers utilizing the VCAP
API, all the typegroups are "{ }" terminated - also with no trailing ','.

Thanks for fixing this!

/Daniel

Reviewed-by: Daniel Machon <daniel.machon at microchip.com> 



More information about the linux-arm-kernel mailing list