[PATCH net v2 0/2] Fix 'ethtool --show-eee' during initial stage
Choong Yong Liang
yong.liang.choong at linux.intel.com
Fri Nov 15 03:11:49 PST 2024
From: Choong Yong Liang <yong.liang.choong at intel.com>
When the MAC boots up with a Marvell PHY and phy_support_eee() is implemented,
the 'ethtool --show-eee' command shows that EEE is enabled, but in actuality,
the driver side is disabled. If we try to enable EEE through
'ethtool --set-eee' for a Marvell PHY, nothing happens because the eee_cfg
matches the setting required to enable EEE in ethnl_set_eee().
This patch series will remove phydev->eee_enabled and replace it with
eee_cfg.eee_enabled. When performing genphy_c45_an_config_eee_aneg(), it
will follow the master configuration to have software and hardware in sync,
allowing 'ethtool --show-eee' to display the correct value during the
initial stage.
v2 changes:
- Implement the prototype suggested by Russell
- Check EEE before calling phy_support_eee()
Thanks to Russell for the proposed prototype in [1].
Reference:
[1] https://patchwork.kernel.org/comment/26121323/
Choong Yong Liang (2):
net: phy: replace phydev->eee_enabled with eee_cfg.eee_enabled
net: stmmac: set initial EEE policy configuration
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +++
drivers/net/phy/phy-c45.c | 11 +++++------
drivers/net/phy/phy_device.c | 6 +++---
include/linux/phy.h | 5 ++---
4 files changed, 13 insertions(+), 12 deletions(-)
--
2.34.1
More information about the linux-arm-kernel
mailing list