[PATCH v2] arm64: Refactor conditional logic

Mark Brown broonie at kernel.org
Wed Nov 13 07:51:52 PST 2024


On Wed, Nov 13, 2024 at 10:48:18AM +0530, Hardevsinh Palaniya wrote:
> Unnecessarily checks ftr_ovr == tmp in an extra else if, which is not
> needed because that condition would already be true by default if the
> previous conditions are not satisfied.

Specifically the first one, if you revise it'd be good to be specific
about the logic here.

> Additionally, all branches set the variable str, making the subsequent
> "if (str)" check redundant

Reviewed-by: Mark Brown <broonie at kernel.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20241113/cb1668e0/attachment.sig>


More information about the linux-arm-kernel mailing list