[PATCHv3 net-next] net: modernize IRQ resource acquisition

Jakub Kicinski kuba at kernel.org
Tue Nov 12 17:23:02 PST 2024


On Tue, 12 Nov 2024 13:14:42 -0800 Rosen Penev wrote:
>  drivers/net/ethernet/moxa/moxart_ether.c      |  6 ++---
>  .../ethernet/samsung/sxgbe/sxgbe_platform.c   | 24 +++++++------------

coccicheck says:

drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:130:6-26: WARNING: Unsigned expression compared with zero: priv -> rxq [ i ] -> irq_no < 0
drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:124:6-26: WARNING: Unsigned expression compared with zero: priv -> txq [ i ] -> irq_no < 0
drivers/net/ethernet/moxa/moxart_ether.c:468:5-8: WARNING: Unsigned expression compared with zero: irq < 0

Is this really worth the review effort? :|

Please do not send any more conversions unless the old API is clearly
deprecated. 
-- 
pw-bot: cr



More information about the linux-arm-kernel mailing list