[PATCH V10 RESEND 1/2] perf util scripting-engines cs-etm: Add map_pgoff to python dictionary

Ian Rogers irogers at google.com
Mon Nov 11 11:51:30 PST 2024


On Fri, Nov 8, 2024 at 9:58 AM Steve Clevenger
<scclevenger at os.amperecomputing.com> wrote:
> On 11/7/2024 10:51 AM, Namhyung Kim wrote:
> > Please use map__pgoff(al->map) instead.  Otherwise you'll get this in
> > the debug build:
> >
> >   util/scripting-engines/trace-event-python.c: In function 'set_sym_in_dict':
> >   util/scripting-engines/trace-event-python.c:814:60: error: 'struct map' has no member named 'pgoff'
> >     814 |                         PyLong_FromUnsignedLongLong(al->map->pgoff));
> >         |                                                            ^~
> >
> > Thanks,
> > Namhyung
> >
>
> Hi Namhyung,
>
> I do not see this compile error, and I typically build perf with debug.
> This make command works through 6.11.0-rc6:
>
> $ make -C tools/perf DEBUG=1 VF=1 CORESIGHT=1 PYTHON=python3
> CONFIG_LIBPYTHON=y CSLIBS=/usr/lib CSINCLUDES=/usr/include install
>
> I can substitute in the map__pgoff() macro in any case.

The map_pgoff was added for reference count checking which changes
struct layout when enabled. More context here:
https://perfwiki.github.io/main/reference-count-checking/

Thanks,
Ian



More information about the linux-arm-kernel mailing list