[PATCH 2/4] kselftest/arm64: Fix printf() warning in the arm64 MTE prctl() test

Mark Brown broonie at kernel.org
Fri Nov 8 07:30:11 PST 2024


On Fri, Nov 08, 2024 at 03:25:46PM +0000, Catalin Marinas wrote:
> On Fri, Nov 08, 2024 at 03:10:59PM +0000, Mark Brown wrote:

> > > -			       (ret & PR_MTE_TCF_MASK), mask);
> > > +			       (int)(ret & PR_MTE_TCF_MASK), mask);

> > Shouldn't we just use a %lx here?  Casts tend to be suspicious...

> It's more like the ret is actually 32-bit and should stay like that when
> bits are masked out. But the bitwise op 'upgrades' it to a long (in
> hindsight, we should not have used UL for the TCF bits and mask).

Hrm, right.  Possibly put the cast on PR_MTE_TCF_MASK rather than on the
expression as a whole then?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20241108/f0f81083/attachment.sig>


More information about the linux-arm-kernel mailing list