[PATCH] PCI: of_property: Assign PCI instead of CPU bus address to dynamic PCI nodes
Andrea della Porta
andrea.porta at suse.com
Fri Nov 8 01:42:56 PST 2024
When populating "ranges" property for a PCI bridge or endpoint,
of_pci_prop_ranges() incorrectly use the CPU bus address of the resource.
In such PCI nodes, the window should instead be in PCI address space. Call
pci_bus_address() on the resource in order to obtain the PCI bus
address.
Fixes: 407d1a51921e ("PCI: Create device tree node for bridge")
Cc: stable at vger.kernel.org
Signed-off-by: Andrea della Porta <andrea.porta at suse.com>
Acked-by: Bjorn Helgaas <bhelgaas at google.com>
Tested-by: Herve Codina <herve.codina at bootlin.com>
---
This patch, originally preparatory for a bigger patchset (see [1]), has
been splitted in a standalone one for better management and because it
contains a bugfix which is probably of interest to stable branch.
drivers/pci/of_property.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/of_property.c b/drivers/pci/of_property.c
index 5a0b98e69795..886c236e5de6 100644
--- a/drivers/pci/of_property.c
+++ b/drivers/pci/of_property.c
@@ -126,7 +126,7 @@ static int of_pci_prop_ranges(struct pci_dev *pdev, struct of_changeset *ocs,
if (of_pci_get_addr_flags(&res[j], &flags))
continue;
- val64 = res[j].start;
+ val64 = pci_bus_address(pdev, &res[j] - pdev->resource);
of_pci_set_address(pdev, rp[i].parent_addr, val64, 0, flags,
false);
if (pci_is_bridge(pdev)) {
--
2.35.3
More information about the linux-arm-kernel
mailing list