[PATCH v2 04/11] clk: qcom: camcc-qcs615: Add QCS615 camera clock controller driver

[Taniya Das]

On 11/1/2024 5:59 PM, Bryan O'Donoghue wrote:
> On 01/11/2024 10:38, Taniya Das wrote:
>> +    .vco_val = 0x2 << 20,
> 
> vco_val = BIT(21)
> 

Will fix it in the next patch.

>> +    .vco_mask = 0x3 << 20,
> 
> Instead of bit shifting couldn't we just use GENMASK ?
> 
> Aside from anything else shifting a hex value by a decimal value isn't 
> the clearest code in the world.
> 
> vco_mask = GENMASK(21, 20)
> 
> Much cleaner.
> 
> drivers/clk/qcom/gcc-sm6115.c
> 
> Same comment for all of the bit-shifts in the series, I appreciate the 
> shifts are what the downstream code does but BIT/GENMASK does this job 
> better.
> 
I agree, will fix it in the next patch.

> Once fixed you can add my
> 
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue at linaro.org>
> 
> to this file


-- 
Thanks & Regards,
Taniya Das.