[PATCH net-next 3/7] net: sparx5: use is_port_rgmii() throughout
Andrew Lunn
andrew at lunn.ch
Thu Nov 7 14:39:40 PST 2024
> +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_port.c
> @@ -1087,6 +1087,9 @@ int sparx5_port_init(struct sparx5 *sparx5,
> ANA_CL_FILTER_CTRL_FILTER_SMAC_MC_DIS,
> sparx5, ANA_CL_FILTER_CTRL(port->portno));
>
> + if (ops->is_port_rgmii(port->portno))
> + return 0;
> +
> /* Configure MAC vlan awareness */
> err = sparx5_port_max_tags_set(sparx5, port);
> if (err)
That looks odd. What has RGMII to do with MAC VLAN awareness?
Maybe it just needs a comment?
Andrew
More information about the linux-arm-kernel
mailing list