[PATCH] drm/imx/dcss: include drm/drm_bridge.h header

Laurentiu Palcu laurentiu.palcu at oss.nxp.com
Mon Nov 4 04:10:54 PST 2024


Hi Arnd,

On Mon, Oct 28, 2024 at 04:35:07PM +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd at arndb.de>
> 
> Compile-testing random configurations leads to failures in
> dcss-kms.c from a missing declaration:
> 
> drivers/gpu/drm/imx/dcss/dcss-kms.c:95:8: error: use of undeclared identifier 'drm_bridge_attach'
>    95 |         ret = drm_bridge_attach(encoder, bridge, NULL,
>       |               ^
> drivers/gpu/drm/imx/dcss/dcss-kms.c:96:5: error: use of undeclared identifier 'DRM_BRIDGE_ATTACH_NO_CONNECTOR'
>    96 |                                 DRM_BRIDGE_ATTACH_NO_CONNECTOR);
>       |                                 ^
> 
> Include the header directly.
> 
> Fixes: 004555a18d57 ("drm/imx/dcss: Allow build with COMPILE_TEST=y")
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
Reviewed-by: Laurentiu Palcu <laurentiu.palcu at oss.nxp.com>

Unfortunately, it appears I lost drm-misc push rights. Maxime, Thomas or
Ville, can you help push this?

Thanks,
Laurentiu

> ---
>  drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c
> index 3ec721afc30c..63a335c62296 100644
> --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c
> +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c
> @@ -5,6 +5,7 @@
>  
>  #include <drm/drm_atomic.h>
>  #include <drm/drm_atomic_helper.h>
> +#include <drm/drm_bridge.h>
>  #include <drm/drm_bridge_connector.h>
>  #include <drm/drm_client_setup.h>
>  #include <drm/drm_drv.h>
> -- 
> 2.39.5
> 



More information about the linux-arm-kernel mailing list