[PATCH v5 15/16] media: platform: Add mali-c55 parameters video node
kernel test robot
lkp at intel.com
Thu May 30 05:54:58 PDT 2024
Hi Daniel,
kernel test robot noticed the following build warnings:
[auto build test WARNING on media-tree/master]
[cannot apply to linuxtv-media-stage/master sailus-media-tree/master linus/master sailus-media-tree/streams v6.10-rc1 next-20240529]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Daniel-Scally/media-uapi-Add-MEDIA_BUS_FMT_RGB202020_1X60-format-code/20240529-233239
base: git://linuxtv.org/media_tree.git master
patch link: https://lore.kernel.org/r/20240529152858.183799-16-dan.scally%40ideasonboard.com
patch subject: [PATCH v5 15/16] media: platform: Add mali-c55 parameters video node
config: nios2-allyesconfig (https://download.01.org/0day-ci/archive/20240530/202405302048.Twi0r71r-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240530/202405302048.Twi0r71r-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405302048.Twi0r71r-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/linux/printk.h:566,
from include/asm-generic/bug.h:22,
from ./arch/nios2/include/generated/asm/bug.h:1,
from include/linux/bug.h:5,
from include/media/media-entity.h:15,
from drivers/media/platform/arm/mali-c55/mali-c55-params.c:9:
drivers/media/platform/arm/mali-c55/mali-c55-params.c: In function 'mali_c55_params_write_config':
>> drivers/media/platform/arm/mali-c55/mali-c55-params.c:504:40: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
504 | dev_dbg(mali_c55->dev, "Invalid parameters buffer size %lu\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:224:29: note: in definition of macro '__dynamic_func_call_cls'
224 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:250:9: note: in expansion of macro '_dynamic_func_call_cls'
250 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:273:9: note: in expansion of macro '_dynamic_func_call'
273 | _dynamic_func_call(fmt, __dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:30: note: in expansion of macro 'dev_fmt'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/media/platform/arm/mali-c55/mali-c55-params.c:504:17: note: in expansion of macro 'dev_dbg'
504 | dev_dbg(mali_c55->dev, "Invalid parameters buffer size %lu\n",
| ^~~~~~~
drivers/media/platform/arm/mali-c55/mali-c55-params.c:504:74: note: format string is defined here
504 | dev_dbg(mali_c55->dev, "Invalid parameters buffer size %lu\n",
| ~~^
| |
| long unsigned int
| %u
vim +504 drivers/media/platform/arm/mali-c55/mali-c55-params.c
480
481 void mali_c55_params_write_config(struct mali_c55 *mali_c55)
482 {
483 struct mali_c55_params *params = &mali_c55->params;
484 enum vb2_buffer_state state = VB2_BUF_STATE_DONE;
485 struct mali_c55_params_buffer *config;
486 struct mali_c55_buffer *buf;
487 size_t block_offset = 0;
488
489 spin_lock(¶ms->buffers.lock);
490
491 buf = list_first_entry_or_null(¶ms->buffers.queue,
492 struct mali_c55_buffer, queue);
493 if (buf)
494 list_del(&buf->queue);
495 spin_unlock(¶ms->buffers.lock);
496
497 if (!buf)
498 return;
499
500 buf->vb.sequence = mali_c55->isp.frame_sequence;
501 config = vb2_plane_vaddr(&buf->vb.vb2_buf, 0);
502
503 if (config->total_size > MALI_C55_PARAMS_MAX_SIZE) {
> 504 dev_dbg(mali_c55->dev, "Invalid parameters buffer size %lu\n",
505 config->total_size);
506 state = VB2_BUF_STATE_ERROR;
507 goto err_buffer_done;
508 }
509
510 /* Walk the list of parameter blocks and process them. */
511 while (block_offset < config->total_size) {
512 const struct mali_c55_block_handler *block_handler;
513 struct mali_c55_params_block_header *block;
514
515 block = (struct mali_c55_params_block_header *)
516 &config->data[block_offset];
517
518 if (block->type >= MALI_C55_PARAM_BLOCK_SENTINEL) {
519 dev_dbg(mali_c55->dev, "Invalid parameters block type\n");
520 state = VB2_BUF_STATE_ERROR;
521 goto err_buffer_done;
522 }
523
524 block_handler = &mali_c55_block_handlers[block->type];
525 if (block->size != block_handler->size) {
526 dev_dbg(mali_c55->dev, "Invalid parameters block size\n");
527 state = VB2_BUF_STATE_ERROR;
528 goto err_buffer_done;
529 }
530
531 block_handler->handler(mali_c55, block);
532
533 block_offset += block->size;
534 }
535
536 err_buffer_done:
537 vb2_buffer_done(&buf->vb.vb2_buf, state);
538 }
539
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the linux-arm-kernel
mailing list