[net PATCH] net: stmmac: update priv->speed to SPEED_UNKNOWN when link down
xiaolei wang
xiaolei.wang at windriver.com
Tue May 28 17:22:01 PDT 2024
On 5/28/24 21:20, Andrew Lunn wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> On Tue, May 28, 2024 at 05:20:10PM +0800, Xiaolei Wang wrote:
>> The CBS parameter can still be configured when the port is
>> currently disconnected and link down. This is unreasonable.
> This sounds like a generic problem. Can the core check the carrier
> status and error out there? Maybe return a useful extack message.
>
> If you do need to return an error code, ENETDOWN seems more
Currently cbs does not check link status. If ops->ndo_setup_tc() returns
failure, there will only be an output of "Specified device failed to
setup cbs hardware offload".
thanks
xiaolei
> appropriate.
>
> Andrew
More information about the linux-arm-kernel
mailing list