[PATCH net-next 5/5] net: stmmac: include linux/io.h rather than asm/io.h

Andrew Halaney ahalaney at redhat.com
Tue May 28 13:48:02 PDT 2024


On Tue, May 28, 2024 at 12:48:58PM GMT, Russell King (Oracle) wrote:
> Include linux/io.h instead of asm/io.h since linux/ includes are
> preferred.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel at armlinux.org.uk>

Reviewed-by: Andrew Halaney <ahalaney at redhat.com>

> ---
>  drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
> index d0c7c2320d8d..d413d76a8936 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c

Any reason you didn't wanna treat the other examples of this similarly?

    ahalaney at x1gen2nano ~/git/linux-next (git)-[tags/next-20240528] % git grep "asm/io.h" drivers/net/ethernet/stmicro/stmmac/
    drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c:#include <asm/io.h>
    drivers/net/ethernet/stmicro/stmmac/dwmac1000_dma.c:#include <asm/io.h>
    drivers/net/ethernet/stmicro/stmmac/dwmac100_core.c:#include <asm/io.h>
    drivers/net/ethernet/stmicro/stmmac/dwmac100_dma.c:#include <asm/io.h>
    drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:#include <asm/io.h>
    ahalaney at x1gen2nano ~/git/linux-next (git)-[tags/next-20240528] % 

Thanks for the series,
Andrew

> @@ -15,7 +15,7 @@
>  #include <linux/crc32.h>
>  #include <linux/slab.h>
>  #include <linux/ethtool.h>
> -#include <asm/io.h>
> +#include <linux/io.h>
>  #include "stmmac.h"
>  #include "stmmac_pcs.h"
>  #include "dwmac1000.h"
> -- 
> 2.30.2
> 




More information about the linux-arm-kernel mailing list