[PATCH] PCI: rockchip-ep: Remove wrong mask on subsys_vendor_id
Krzysztof Wilczyński
kw at linux.com
Fri May 17 04:18:01 PDT 2024
> Remove wrong mask on subsys_vendor_id. Both the Vendor ID and Subsystem
> Vendor ID are u16 variables and are written to a u32 register of the
> controller. The Subsystem Vendor ID was always 0 because the u16 value
> was masked incorrectly with GENMASK(31,16) resulting in all lower 16
> bits being set to 0 prior to the shift.
>
> Remove both masks as they are unnecessary and set the register correctly
> i.e., the lower 16-bits are the Vendor ID and the upper 16-bits are the
> Subsystem Vendor ID.
>
> This is documented in the RK3399 TRM section 17.6.7.1.17
Applied to controller/rockchip, thank you!
[1/1] PCI: rockchip-ep: Remove wrong mask on subsys_vendor_id
https://git.kernel.org/pci/pci/c/2f014bf195ae
Krzysztof
More information about the linux-arm-kernel
mailing list