[PATCH 12/17] irqchip: Add support for LAN966x OIC
Herve Codina
herve.codina at bootlin.com
Mon May 13 05:50:49 PDT 2024
Hi Steen,
On Wed, 8 May 2024 08:08:30 +0000
<Steen.Hegelund at microchip.com> wrote:
...
> > +/* Mapping of source to destination interrupts (_n = 0..8) */
>
> Are the indices really needed on LAN966X_OIC_DST_INTR_MAP* and _IDENT*
> You do not appear to be using them?
>
>
> > +#define LAN966X_OIC_DST_INTR_MAP(_n) 0x78
Indeed, I missed them.
These registers are defined from 0 to 8 in the document:
https://microchip-ung.github.io/lan9662_reginfo/reginfo_LAN9662.html?select=cpu,intr
The code use only the indice 0.
In the next iteration, I will keep indices and update the definition of
registers like that:
#define LAN966X_OIC_DST_INTR_MAP(_n) (0x78 + (_n) * 4)
Best regards
Hervé
More information about the linux-arm-kernel
mailing list