[PATCH v2 11/18] media: venus: Refactor struct hfi_uncompressed_plane_info
Bryan O'Donoghue
bryan.odonoghue at linaro.org
Thu May 9 16:38:14 PDT 2024
On 07/05/2024 17:27, Ricardo Ribalda wrote:
> This field is never used, but if we remove it we would change the size
> of the struct and can lead to behavior change. Stay on the safe side by
> replacing the single element array with a single element field.
>
> This fixes the following cocci warning:
> drivers/media/platform/qcom/venus/hfi_helper.h:1003:43-60: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
>
> Signed-off-by: Ricardo Ribalda <ribalda at chromium.org>
> ---
> drivers/media/platform/qcom/venus/hfi_helper.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media/platform/qcom/venus/hfi_helper.h
> index 7c0edef263ae..eb0a4c64b7ef 100644
> --- a/drivers/media/platform/qcom/venus/hfi_helper.h
> +++ b/drivers/media/platform/qcom/venus/hfi_helper.h
> @@ -1000,7 +1000,7 @@ struct hfi_uncompressed_plane_constraints {
> struct hfi_uncompressed_plane_info {
> u32 format;
> u32 num_planes;
> - struct hfi_uncompressed_plane_constraints plane_constraints[1];
> + struct hfi_uncompressed_plane_constraints plane_constraints;
> };
>
> struct hfi_uncompressed_format_supported {
>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue at linaro.org>
More information about the linux-arm-kernel
mailing list