[PATCH v6 0/2] regulator: sun20i: Add Allwinner D1 LDOs driver

Chen-Yu Tsai wens at kernel.org
Thu May 9 08:31:05 PDT 2024


From: Chen-Yu Tsai <wens at csie.org>

Hi,

This is v6 of the Allwinner D1 LDO driver series, separated by subsystem.
I've picked up this work from Samuel.  This part contains just the
regulator driver bits. The sunxi SRAM binding part will be sent out after
the merge window due to a conflict in next.

Unlike what the original cover letter mentioned, it is perfectly OK to
merge this part separately. The SRAM driver changes were already merged
some time ago, and the SRAM bindings depend on the regulator bindings,
not the other way around.

Changes in v6:
- Include linux/of.h in the regulator driver to fix the "implicit
  declaration of function of_'device_get_match_data'" and unknown
  type 'struct of_device_id' errors.


Original cover letter:

This series adds the binding and driver for one of the two pairs of LDOs
inside the Allwinner D1 SoC. I am splitting up the two pairs of LDOs to
unblock merging the SoC devicetree; the analog LDOs depend on the audio
codec binding, but they are not required to boot.

A binding and driver change is required for the SRAM controller, to
accept the regulators device as its child node.

The example for the regulator device binding is in SRAM controller
binding document, per Rob's request to keep MFD examples in one place.

Because of this, at least the first 3 patches need to be taken together
through the regulator tree, though it should be fine to merge the whole
series that way.

Changes in v5:
 - Correct the voltage calculation for the non-linearity around 1.6 V.

Changes in v4:
 - Fix the order of the maintainer/description sections
 - Replace unevaluatedProperties with "additionalProperties: false"
 - Drop the analog LDOs until the codec binding is ready
 - Drop the analog LDOs until the codec binding is ready
 - Remove unevaluatedProperties from regulators schema reference
 - Check the compatible string instead of the node name

Changes in v3:
 - Add "reg" property to bindings
 - Add "unevaluatedProperties: true" to regulator nodes
 - Minor changes to regulator node name patterns
 - Remove system-ldos example (now added in the parent binding)
 - Adjust control flow in sun20i_regulator_get_regmap() for clarity
 - Require the regulators node to have a unit address
 - Reference the regulator schema from the SRAM controller schema
 - Move the system LDOs example to the SRAM controller schema
 - Reorder the patches so the example passes validation

Changes in v2:
 - Remove syscon property from bindings
 - Update binding examples to fix warnings and provide context
 - Use decimal numbers for .n_voltages instead of field widths
 - Get the regmap from the parent device instead of a property/phandle


Samuel Holland (2):
  regulator: dt-bindings: Add Allwinner D1 system LDOs
  regulator: sun20i: Add Allwinner D1 LDOs driver

 .../allwinner,sun20i-d1-system-ldos.yaml      |  37 +++++
 drivers/regulator/Kconfig                     |   8 +
 drivers/regulator/Makefile                    |   1 +
 drivers/regulator/sun20i-regulator.c          | 157 ++++++++++++++++++
 4 files changed, 203 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/regulator/allwinner,sun20i-d1-system-ldos.yaml
 create mode 100644 drivers/regulator/sun20i-regulator.c

-- 
2.39.2




More information about the linux-arm-kernel mailing list