[PATCH 01/19] amba: store owner from modules with amba_driver_register()
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Thu Mar 28 00:51:55 PDT 2024
On 27/03/2024 21:33, Andi Shyti wrote:
> Hi Krzysztof,
>
> ...
>
>> /**
>> - * amba_driver_register - register an AMBA device driver
>> + * __amba_driver_register - register an AMBA device driver
>> * @drv: amba device driver structure
>> + * @owner: owning module/driver
>> *
>> * Register an AMBA device driver with the Linux device model
>> * core. If devices pre-exist, the drivers probe function will
>> * be called.
>> */
>> -int amba_driver_register(struct amba_driver *drv)
>> +int __amba_driver_register(struct amba_driver *drv,
>
> ...
>
>> +/*
>> + * use a macro to avoid include chaining to get THIS_MODULE
>> + */
>
> Should the documentation be moved here? Well... I don't see any
> documentation linking this file yet, but in case it comes we want
> documented amba_driver_register() rather than
> __amba_driver_register().
>
That's just a wrapper, not API... why would we care to have kerneldoc
for it?
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list