[PATCH 1/2] dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Add missing properties
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Mon Mar 25 17:49:01 PDT 2024
The raspberrypi,bcm2835-firmware devices requires a dma-ranges property,
and, as a result, also needs to specify #address-cells and #size-cells.
Those properties have been added to thebcm2835-rpi.dtsi in commits
be08d278eb09 ("ARM: dts: bcm283x: Add cells encoding format to firmware
bus") and 55c7c0621078 ("ARM: dts: bcm283x: Fix vc4's firmware bus DMA
limitations"), but the DT bindings haven't been updated, resulting in
validation errors:
arch/arm64/boot/dts/broadcom/bcm2711-rpi-4-b.dtb: firmware: '#address-cells', '#size-cells', 'dma-ranges', 'gpio' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/arm/bcm/raspberrypi,bcm2835-firmware.yaml#
Fix this by adding the properties to the bindings.
Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
.../arm/bcm/raspberrypi,bcm2835-firmware.yaml | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
index 39e3c248f5b7..dc38f2be7ad6 100644
--- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
+++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
@@ -25,6 +25,14 @@ properties:
- const: raspberrypi,bcm2835-firmware
- const: simple-mfd
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 1
+
+ dma-ranges: true
+
mboxes:
maxItems: 1
@@ -81,6 +89,9 @@ properties:
required:
- compatible
+ - "#address-cells"
+ - "#size-cells"
+ - dma-ranges
- mboxes
additionalProperties: false
@@ -89,6 +100,11 @@ examples:
- |
firmware {
compatible = "raspberrypi,bcm2835-firmware", "simple-mfd";
+
+ #address-cells = <1>;
+ #size-cells = <1>;
+ dma-ranges;
+
mboxes = <&mailbox>;
firmware_clocks: clocks {
--
Regards,
Laurent Pinchart
More information about the linux-arm-kernel
mailing list