[PATCH] dmaengine: owl: fix register access functions

Peter Korsgaard peter at korsgaard.com
Fri Mar 22 06:36:29 PDT 2024


>>>>> "Arnd" == Arnd Bergmann <arnd at kernel.org> writes:

 > From: Arnd Bergmann <arnd at arndb.de>
 > When building with 'make W=1', clang notices that the computed register
 > values are never actually written back but instead the wrong variable
 > is set:

 > drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
 >   244 |         u32 regval;
 >       |             ^
 > drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
 >   268 |         u32 regval;
 >       |             ^

 > Change these to what was most likely intended.

 > Fixes: 47e20577c24d ("dmaengine: Add Actions Semi Owl family S900 DMA driver")
 > Signed-off-by: Arnd Bergmann <arnd at arndb.de>

Good catch!

Reviewed-by: Peter Korsgaard <peter at korsgaard.com>

-- 
Bye, Peter Korsgaard



More information about the linux-arm-kernel mailing list