[PATCH v2 01/15] dmaengine: bcm2835: Fix several spellos

Florian Fainelli florian.fainelli at broadcom.com
Wed Mar 13 09:38:41 PDT 2024


On 3/13/24 08:26, Andrea della Porta wrote:
> On 08:00 Wed 13 Mar     , Florian Fainelli wrote:
>>
>>
>> On 3/13/2024 7:08 AM, Andrea della Porta wrote:
>>> Fixed Codespell reported warnings about spelling and coding convention
>>> violations, among which there are also a couple potential operator
>>> precedence issue in macroes.

and s/macroes/macros/

>>>
>>> Signed-off-by: Andrea della Porta <andrea.porta at suse.com>
>>
>> There are no spelling errors being fixed in this commit, this is purely
>> stylistic and conforming to the Linux coding style guidelines.
> 
> -	/* detect a size missmatch */
> -	if (buf_len && (d->size != buf_len))
> +	/* detect a size mismatch */
> +	if (buf_len && d->size != buf_len)
> 
> Isn't 'missmatch' a spelling error? Maybe I can drop the word 'several', since it's
> indeed only one...

Can we agree this was easy to miss when 99% of the changes are 
stylistic? The summary is that the commit subject and the message are 
not describing what this patch is about.
-- 
Florian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4221 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20240313/f2a49080/attachment.p7s>


More information about the linux-arm-kernel mailing list