[PATCH v3 2/9] ARM: tlbflush: Make TLB flushes into static inlines

Sami Tolvanen samitolvanen at google.com
Mon Mar 11 14:36:58 PDT 2024


On Mon, Mar 11, 2024 at 7:51 PM Linus Walleij <linus.walleij at linaro.org> wrote:
>
> On Mon, Mar 11, 2024 at 4:35 PM Sami Tolvanen <samitolvanen at google.com> wrote:
> > On Mon, Mar 11, 2024 at 3:04 AM Ard Biesheuvel <ardb at kernel.org> wrote:
> >>
> > > This works for some function attributes (e.g., __efiapi is used like
> > > this), but the attribute specifier to which __nocfi resolves does not
> > > appear to be usable in the same manner.
> > >
> > > Best would be to annotate the asm code using
> > > SYM_TYPED_FUNC_START/_END, so that the CFI machinery is invoked at the
> > > call site to validate the function type of the destination.
> >
> > Agreed, ideally we would annotate indirectly called assembly functions
> > with CFI types and avoid __nocfi wrappers.
>
> I'm taking a stab at SYM_TYPED_FUNC_* for ARM, as we don't have them
> yet.

Does the default implementation in include/linux/cfi_types.h not work
on arm for some reason?

Sami



More information about the linux-arm-kernel mailing list