[PATCH v6 3/4] ASoC: dt-bindings: fsl-sai: allow only one dma-names

Conor Dooley conor at kernel.org
Fri Mar 8 08:58:16 PST 2024


On Fri, Mar 08, 2024 at 10:30:52AM -0500, Frank Li wrote:
> Some sai only connect one direction dma (rx/tx) in SOC. For example:
> imx8qxp sai5 only connect tx dma channel. So allow only one "rx" or "tx"
> for dma-names.
> 
> Remove description under dmas because no user use index to get dma channel.
> All user use 'dma-names' to get correct dma channel. dma-names already in
> 'required' list.
> 
> Acked-by: Conor Dooley <conor.dooley at microchip.com>
> Signed-off-by: Frank Li <Frank.Li at nxp.com>

Please drop my ack from this, this isn't the patch I acked originally
and we were having a conversation as recently as yesterday on v4 about
this patch because Rob didn't like this approach. His suggestion is
better than the one I gave on v4 that you have used here.

Please give it a few days between resubmissions, and do not send new
versions of a series every day. It is very confusing to have different
conversions on three versions of this patch in my inbox all at the same
time.

Thanks,
Conor.

> ---
>  Documentation/devicetree/bindings/sound/fsl,sai.yaml | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> index 2456d958adeef..93e7737a49a7b 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> @@ -81,15 +81,13 @@ properties:
>  
>    dmas:
>      minItems: 1
> -    items:
> -      - description: DMA controller phandle and request line for RX
> -      - description: DMA controller phandle and request line for TX
> +    maxItems: 2
>  
>    dma-names:
>      minItems: 1
> +    maxItems: 2
>      items:
> -      - const: rx
> -      - const: tx
> +      enum: [ rx, tx ]
>  
>    interrupts:
>      items:
> 
> -- 
> 2.34.1
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20240308/cd1c5dbb/attachment.sig>


More information about the linux-arm-kernel mailing list