[PATCH] PCI: brcmstb: fix broken brcm_pcie_mdio_write() polling

Stefan Wahren wahrenst at gmx.net
Thu Mar 7 10:59:18 PST 2024


Am 02.03.24 um 10:45 schrieb Stefan Wahren:
> Hi,
>
> Am 17.02.24 um 18:27 schrieb Florian Fainelli:
>>
>>
>> On 2/17/2024 5:37 AM, Stefan Wahren wrote:
>>> From: Jonathan Bell <jonathan at raspberrypi.com>
>>>
>>> MDIO_WR_DONE() tests bit 31, which is always 0 (==done) as
>>> readw_poll_timeout_atomic does a 16-bit read. Replace with the readl
>>> variant.
>>>
>>> Fixes: ca5dcc76314d ("PCI: brcmstb: Replace status loops with
>>> read_poll_timeout_atomic()")
>>> Signed-off-by: Jonathan Bell <jonathan at raspberrypi.com>
>>> Signed-off-by: Stefan Wahren <wahrenst at gmx.net>
>>
>> Excellent catch! Not sure what the real world impact was.
>>
>> Acked-by: Florian Fainelli <florian.fainelli at broadcom.com>
> is there anything what prevents this patch from being applied?
ping




More information about the linux-arm-kernel mailing list