[PATCH 5/6] ipmi: kcs_bmc_aspeed: Convert to platform remove callback returning void

Andrew Jeffery andrew at codeconstruct.com.au
Tue Mar 5 17:57:55 PST 2024


On Tue, 2024-03-05 at 17:27 +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Reviewed-by: Andrew Jeffery <andrew at codeconstruct.com.au>

Thanks!



More information about the linux-arm-kernel mailing list