[SPAM] [PATCH v2 04/11] i2c: nomadik: simplify IRQ masking logic

Andi Shyti andi.shyti at kernel.org
Fri Mar 1 16:39:39 PST 2024


Hi Theo,

On Thu, Feb 29, 2024 at 07:10:52PM +0100, Théo Lebrun wrote:
> IRQ_MASK and I2C_CLEAR_ALL_INTS are redundant. One masks the top three

if I2C_CLEAR_ALL_INTS is redundant why don't you remove it?

> bits off as reserved, the other one masks the reserved IRQs inside the
> u32. Get rid of IRQ_MASK and only use the most restrictive mask.

Why is IRQ_MASK redundant? What happens if you write in the
reserved bits?

Can you please explain a bit better the change you did?

Thanks,
Andi

> Reviewed-by: Linus Walleij <linus.walleij at linaro.org>
> Signed-off-by: Théo Lebrun <theo.lebrun at bootlin.com>



More information about the linux-arm-kernel mailing list