[PATCH] dmaengine: mxs-dma: Add check for dma_set_max_seg_size in mxs_dma_probe()
Peng Fan
peng.fan at nxp.com
Wed Jun 26 02:02:09 PDT 2024
> Subject: [PATCH] dmaengine: mxs-dma: Add check for
> dma_set_max_seg_size in mxs_dma_probe()
Please read
https://lore.kernel.org/all/ZiocjS6tbeTt2mPD@matsya/
Regards,
Peng.
>
> As the possible failure of the dma_set_max_seg_size(), we should
> better check the return value of the dma_set_max_seg_size().
>
> Fixes: a580b8c5429a ("dmaengine: mxs-dma: add dma support for
> i.MX23/28")
> Signed-off-by: Ma Ke <make24 at iscas.ac.cn>
> ---
> drivers/dma/mxs-dma.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c index
> cfb9962417ef..90cbb9b04b02 100644
> --- a/drivers/dma/mxs-dma.c
> +++ b/drivers/dma/mxs-dma.c
> @@ -798,7 +798,9 @@ static int mxs_dma_probe(struct
> platform_device *pdev)
> mxs_dma->dma_device.dev = &pdev->dev;
>
> /* mxs_dma gets 65535 bytes maximum sg size */
> - dma_set_max_seg_size(mxs_dma->dma_device.dev,
> MAX_XFER_BYTES);
> + ret = dma_set_max_seg_size(mxs_dma->dma_device.dev,
> MAX_XFER_BYTES);
> + if (ret)
> + return ret;
>
> mxs_dma->dma_device.device_alloc_chan_resources =
> mxs_dma_alloc_chan_resources;
> mxs_dma->dma_device.device_free_chan_resources =
> mxs_dma_free_chan_resources;
> --
> 2.25.1
>
More information about the linux-arm-kernel
mailing list