[PATCH net-next v8 11/13] net: phy: add driver for built-in 2.5G ethernet PHY on MT7988

[SkyLake Huang (黃啟澤)]

> > +
> > +#define MTK_2P5GPHY_ID_MT7988(0x00339c11)
> > +
> > +#define MT7988_2P5GE_PMB "mediatek/mt7988/i2p5ge-phy-pmb.bin"
> 
> You probably want a MODULE_FIRMWARE() so the firmware gets placed
> into
> the initrd.
> 
Agree. I'll add MODULE_FIRMWARE() in next version.

> > +#define BASE100T_STATUS_EXTEND(0x10)
> > +#define BASE1000T_STATUS_EXTEND(0x11)
> > +#define EXTEND_CTRL_AND_STATUS(0x16)
> 
> These don't appear to be used.
> 
>       Andrew

Sorry for this left-over. I'll remove these three unused macro names
and PHY_AUX_DPX_MASK.

BRs,
Sky