[boot-wrapper 3/7] aarch64: Remove TSCXT bit set from SCTLR_EL2_RESET
Andre Przywara
andre.przywara at arm.com
Thu Jun 6 09:39:23 PDT 2024
On Thu, 6 Jun 2024 14:36:24 +0100
Luca Fancellu <luca.fancellu at arm.com> wrote:
> From the specification SCTLR_EL2.TSCXT is RES1 only "When
> FEAT_CSV2_2 is not implemented, FEAT_CSV2_1p2 is not
> implemented, HCR_EL2.E2H == 1 and HCR_EL2.TGE == 1", so
> given that HCR_EL2.E2H is set by bootwrapper before to a
> value of zero, the condition above can't happen and from
> the specification the bit is RES0.
>
> Fix the macro removing the bit.
>
> Signed-off-by: Luca Fancellu <luca.fancellu at arm.com>
Reviewed-by: Andre Przywara <andre.przywara at arm.com>
Thanks,
Andre
> ---
> arch/aarch64/include/asm/cpu.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/aarch64/include/asm/cpu.h b/arch/aarch64/include/asm/cpu.h
> index 124ef916ddfc..846b89f8405d 100644
> --- a/arch/aarch64/include/asm/cpu.h
> +++ b/arch/aarch64/include/asm/cpu.h
> @@ -30,8 +30,8 @@
> BIT(11) | BIT(5) | BIT(4))
>
> #define SCTLR_EL2_RES1 \
> - (BIT(29) | BIT(28) | BIT(23) | BIT(22) | BIT(20) | BIT(18) | \
> - BIT(16) | BIT(11) | BIT(5) | BIT(4))
> + (BIT(29) | BIT(28) | BIT(23) | BIT(22) | BIT(18) | BIT(16) | \
> + BIT(11) | BIT(5) | BIT(4))
>
> #define SCTLR_EL1_RES1 \
> (BIT(29) | BIT(28) | BIT(23) | BIT(22) | BIT(20) | BIT(11) | \
More information about the linux-arm-kernel
mailing list