[PATCH v4 6/9] KVM: arm64: Eagerly restore host fpsimd/sve state in pKVM

[Mark Brown]

On Tue, Jun 04, 2024 at 02:52:52PM +0100, Marc Zyngier wrote:
> Mark Brown <broonie at kernel.org> wrote:
> > On Tue, Jun 04, 2024 at 01:03:07PM +0100, Fuad Tabba wrote:

> > > You suggested inlining this, but since this is static, I think the
> > > compiler would do that. Even though it's only one line, it maintains
> > > symmetry with fpsimd_sve_sync().

> > The reason I was suggesting inlining was that it removes the need to
> > name the function.

> You're missing the point.

I think not.

> The name is important, and the current name is correct. We use *flush
> (resp. *sync) for operations that need to happen before (resp. after)
> the entry into the guest. This is consistent with the rest of the code
> base for most of the subsystems KVM/arm64 deals with.

Hence my suggestion to add documentation to the function to avoid the
risk of surprises, the above text explains the motivation for the
suggestion that Faud is responding to.  Either approach would work.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20240604/0804376b/attachment.sig>