[PATCH v3 01/11] KVM: arm64: Reintroduce __sve_save_state

[Fuad Tabba]

Hi Mark,

On Fri, May 31, 2024 at 1:26 PM Mark Brown <broonie at kernel.org> wrote:
>
> On Tue, May 28, 2024 at 01:59:04PM +0100, Fuad Tabba wrote:
>
> > This reverts commit e66425fc9ba3 ("KVM: arm64: Remove unused
> > __sve_save_state").
>
> > +void __sve_save_state(void *sve_pffr, u32 *fpsr);
>
> The prototype says this takes 2 arguments...
>
> > +SYM_FUNC_START(__sve_save_state)
> > +     mov     x2, #1
> > +     sve_save 0, x1, x2, 3
>
> ...but the macro takes and the function supplies 3 arguments.  This was
> a bug in the code at the time you did the revert (the prototype had been
> missed when adding save_ffr) but we should still fix it.

Thanks for spotting this! I will fix it on the respin.

Cheers,
/fuad