[PATCH v3 1/1] watchdog: imx7ulp_wdt: move post_rcs_wait into struct imx_wdt_hw_feature

Guenter Roeck linux at roeck-us.net
Mon Jul 15 11:01:57 PDT 2024


On 7/15/24 10:16, Fabio Estevam wrote:
> Hi Frank,
> 
> On Mon, Jul 15, 2024 at 2:07 PM Frank Li <Frank.Li at nxp.com> wrote:
>>
>> Move post_rcs_wait into struct imx_wdt_hw_feature to simplify code logic
>> for different compatible strings
>>
>> i.MX93 and i.MX8ULP watchdog do not need to wait 2.5 clocks after RCS is
>> done. Set post_rcs_wait to false explicitly to maintain code consistency.
>>
>> Reviewed-by: Guenter Roeck <linux at roeck-us.net>
>> Signed-off-by: Alice Guo <alice.guo at nxp.com>
>> Reviewed-by: Ye Li <ye.li at nxp.com>
>> Signed-off-by: Frank Li <Frank.Li at nxp.com>
> 
> It looks better now, thanks:
> 

Not in my opinion. As requested in my other e-mail, please drop my Reviewed-by: tag.

Guenter

> Reviewed-by: Fabio Estevam <festevam at gmail.com>




More information about the linux-arm-kernel mailing list