[PATCH] arm64: dts: rockchip: Add avdd supplies to hdmi on rock64

Diederik de Haas didi.debian at cknow.org
Thu Jul 4 12:18:33 PDT 2024


Pine64's Rock64 was missing the avdd supply properties on the hdmi node,
causing the following warnings:

  dwhdmi-rockchip ff3c0000.hdmi: supply avdd-0v9 not found, using dummy regulator
  dwhdmi-rockchip ff3c0000.hdmi: supply avdd-1v8 not found, using dummy regulator

In the Rock64 Schematic document version 2.0 those supplies are marked
as DVIDEO_AVDD_1V0 and DVIDEO_AVDD_1V8 respectively, but in version 3.0
those are named HDMI_AVDD_1V0 and HDMI_AVDD_1V8, which is a bit clearer.
In both versions those are connected to LDO3 and LDO1 respectively.

While the DeviceTree property is named 'avdd-0v9-supply' the
'rockchip,dw-hdmi.yaml' binding document notes the following:

  A 0.9V supply that powers up the SoC internal circuitry. The actual
  pin name varies between the different SoCs and is usually
  HDMI_TX_AVDD_0V9 or sometimes HDMI_AVDD_1V0.

So the 'vdd_10' reference is not an error.

Signed-off-by: Diederik de Haas <didi.debian at cknow.org>
---
 arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
index 229fe9da9c2d..90fef766f3ae 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
@@ -154,6 +154,8 @@ &gmac2io {
 };
 
 &hdmi {
+	avdd-0v9-supply = <&vdd_10>;
+	avdd-1v8-supply = <&vcc_18>;
 	status = "okay";
 };
 
-- 
2.45.2




More information about the linux-arm-kernel mailing list