[PATCH net] net: stmmac: dwmac4: fix PCS duplex mode decode

[Russell King (Oracle)]

On Wed, Jul 03, 2024 at 06:07:54PM +0300, Serge Semin wrote:
> On Wed, Jul 03, 2024 at 04:06:54PM +0200, Andrew Lunn wrote:
> > On Wed, Jul 03, 2024 at 01:24:40PM +0100, Russell King (Oracle) wrote:
> > > dwmac4 was decoding the duplex mode from the GMAC_PHYIF_CONTROL_STATUS
> > > register incorrectly, using GMAC_PHYIF_CTRLSTATUS_LNKMOD_MASK (value 1)
> > > rather than GMAC_PHYIF_CTRLSTATUS_LNKMOD (bit 16). Fix this.
> > 
> > This appears to be the only use of
> > GMAC_PHYIF_CTRLSTATUS_LNKMOD_MASK. Maybe it should be removed after
> > this change?
> 
> There is a PCS-refactoring work initiated by Russell, which besides of
> other things may eventually imply dropping this macro:
> https://lore.kernel.org/netdev/20240624132802.14238-6-fancer.lancer@gmail.com/
> So unless it is strongly required I guess there is no much need in
> respinning this patch or implementing additional one for now.

Nevertheless, a respin is worth doing with Andrew's suggested change
because this patch will impact the refactoring work even without that
change. We might as well have a complete patch for this change.

(Besides, I've already incorporated Andrew's feedback!)

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!