[PATCH 3/3] spi: spi-rockchip: Fix unused chip select line when using gpio cs
Luis de Arquer
ldearquer at gmail.com
Sat Jan 27 01:48:00 PST 2024
On Fri, 2024-01-26 at 20:47 +0100, Luis de Arquer wrote:
> This change allows the DT to use native c1 for a device while leaving
> native cs0 reserved for allowing gpio cs operation
>
Actually, I think this comment is the other way around -reserve cs1 and use cs0 for device.
Before, it was using cs0 for gpio operation always.
>
> - ROCKCHIP_SPI_SET_BITS(rs->regs + ROCKCHIP_SPI_SER, 1);
> + ROCKCHIP_SPI_SET_BITS(rs->regs + ROCKCHIP_SPI_SER, ctlr->unused_native_cs);
s/ctlr->unused_native_cs/BIT(ctlr->unused_native_cs)/
I mixed up cs numbers and bitmask, sorry.
I'll fix for v2
Luis
More information about the linux-arm-kernel
mailing list