[PATCH v7 2/3] pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support
kernel test robot
lkp at intel.com
Thu Jan 25 16:38:04 PST 2024
Hi Aleksandr,
kernel test robot noticed the following build errors:
[auto build test ERROR on robh/for-next]
[also build test ERROR on sunxi/sunxi/for-next linus/master v6.8-rc1 next-20240125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Aleksandr-Shubin/dt-bindings-pwm-Add-binding-for-Allwinner-D1-T113-S3-R329-PWM-controller/20240125-152445
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20240125072032.1151383-3-privatesub2%40gmail.com
patch subject: [PATCH v7 2/3] pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20240126/202401260832.fN2PCI3u-lkp@intel.com/config)
compiler: clang version 18.0.0git (https://github.com/llvm/llvm-project a31a60074717fc40887cfe132b77eec93bedd307)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240126/202401260832.fN2PCI3u-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401260832.fN2PCI3u-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
In file included from drivers/pwm/pwm-sun20i.c:16:
In file included from include/linux/io.h:13:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
547 | val = __raw_readb(PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
560 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
| ^
In file included from drivers/pwm/pwm-sun20i.c:16:
In file included from include/linux/io.h:13:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
573 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
| ^
In file included from drivers/pwm/pwm-sun20i.c:16:
In file included from include/linux/io.h:13:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
584 | __raw_writeb(value, PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
594 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
604 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
>> drivers/pwm/pwm-sun20i.c:288:3: error: field designator 'owner' does not refer to any field in type 'const struct pwm_ops'
288 | .owner = THIS_MODULE,
| ~^~~~~~~~~~~~~~~~~~~
>> drivers/pwm/pwm-sun20i.c:297:36: warning: declaration of 'struct platform_device' will not be visible outside of this function [-Wvisibility]
297 | static int sun20i_pwm_probe(struct platform_device *pdev)
| ^
>> drivers/pwm/pwm-sun20i.c:302:16: error: call to undeclared function 'devm_kzalloc'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
302 | sun20i_chip = devm_kzalloc(&pdev->dev, sizeof(*sun20i_chip), GFP_KERNEL);
| ^
>> drivers/pwm/pwm-sun20i.c:302:34: error: incomplete definition of type 'struct platform_device'
302 | sun20i_chip = devm_kzalloc(&pdev->dev, sizeof(*sun20i_chip), GFP_KERNEL);
| ~~~~^
drivers/pwm/pwm-sun20i.c:297:36: note: forward declaration of 'struct platform_device'
297 | static int sun20i_pwm_probe(struct platform_device *pdev)
| ^
>> drivers/pwm/pwm-sun20i.c:306:22: error: call to undeclared function 'devm_platform_ioremap_resource'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
306 | sun20i_chip->base = devm_platform_ioremap_resource(pdev, 0);
| ^
>> drivers/pwm/pwm-sun20i.c:306:20: error: incompatible integer to pointer conversion assigning to 'void *' from 'int' [-Wint-conversion]
306 | sun20i_chip->base = devm_platform_ioremap_resource(pdev, 0);
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pwm/pwm-sun20i.c:310:51: error: incomplete definition of type 'struct platform_device'
310 | sun20i_chip->clk_bus = devm_clk_get_enabled(&pdev->dev, "bus");
| ~~~~^
drivers/pwm/pwm-sun20i.c:297:36: note: forward declaration of 'struct platform_device'
297 | static int sun20i_pwm_probe(struct platform_device *pdev)
| ^
>> drivers/pwm/pwm-sun20i.c:312:10: error: call to undeclared function 'dev_err_probe'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
312 | return dev_err_probe(&pdev->dev, PTR_ERR(sun20i_chip->clk_bus),
| ^
drivers/pwm/pwm-sun20i.c:312:29: error: incomplete definition of type 'struct platform_device'
312 | return dev_err_probe(&pdev->dev, PTR_ERR(sun20i_chip->clk_bus),
| ~~~~^
drivers/pwm/pwm-sun20i.c:297:36: note: forward declaration of 'struct platform_device'
297 | static int sun20i_pwm_probe(struct platform_device *pdev)
| ^
drivers/pwm/pwm-sun20i.c:315:52: error: incomplete definition of type 'struct platform_device'
315 | sun20i_chip->clk_hosc = devm_clk_get_enabled(&pdev->dev, "hosc");
| ~~~~^
drivers/pwm/pwm-sun20i.c:297:36: note: forward declaration of 'struct platform_device'
297 | static int sun20i_pwm_probe(struct platform_device *pdev)
| ^
drivers/pwm/pwm-sun20i.c:317:29: error: incomplete definition of type 'struct platform_device'
317 | return dev_err_probe(&pdev->dev, PTR_ERR(sun20i_chip->clk_hosc),
| ~~~~^
drivers/pwm/pwm-sun20i.c:297:36: note: forward declaration of 'struct platform_device'
297 | static int sun20i_pwm_probe(struct platform_device *pdev)
| ^
drivers/pwm/pwm-sun20i.c:320:52: error: incomplete definition of type 'struct platform_device'
320 | sun20i_chip->clk_apb0 = devm_clk_get_enabled(&pdev->dev, "apb0");
| ~~~~^
drivers/pwm/pwm-sun20i.c:297:36: note: forward declaration of 'struct platform_device'
297 | static int sun20i_pwm_probe(struct platform_device *pdev)
| ^
drivers/pwm/pwm-sun20i.c:322:29: error: incomplete definition of type 'struct platform_device'
322 | return dev_err_probe(&pdev->dev, PTR_ERR(sun20i_chip->clk_apb0),
| ~~~~^
drivers/pwm/pwm-sun20i.c:297:36: note: forward declaration of 'struct platform_device'
297 | static int sun20i_pwm_probe(struct platform_device *pdev)
| ^
drivers/pwm/pwm-sun20i.c:325:59: error: incomplete definition of type 'struct platform_device'
325 | sun20i_chip->rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
| ~~~~^
drivers/pwm/pwm-sun20i.c:297:36: note: forward declaration of 'struct platform_device'
297 | static int sun20i_pwm_probe(struct platform_device *pdev)
| ^
drivers/pwm/pwm-sun20i.c:327:29: error: incomplete definition of type 'struct platform_device'
327 | return dev_err_probe(&pdev->dev, PTR_ERR(sun20i_chip->rst),
| ~~~~^
drivers/pwm/pwm-sun20i.c:297:36: note: forward declaration of 'struct platform_device'
297 | static int sun20i_pwm_probe(struct platform_device *pdev)
| ^
drivers/pwm/pwm-sun20i.c:330:33: error: incomplete definition of type 'struct platform_device'
330 | ret = of_property_read_u32(pdev->dev.of_node, "allwinner,pwm-channels",
| ~~~~^
drivers/pwm/pwm-sun20i.c:297:36: note: forward declaration of 'struct platform_device'
297 | static int sun20i_pwm_probe(struct platform_device *pdev)
| ^
drivers/pwm/pwm-sun20i.c:341:29: error: incomplete definition of type 'struct platform_device'
341 | return dev_err_probe(&pdev->dev, ret, "failed to deassert reset\n");
| ~~~~^
drivers/pwm/pwm-sun20i.c:297:36: note: forward declaration of 'struct platform_device'
297 | static int sun20i_pwm_probe(struct platform_device *pdev)
| ^
drivers/pwm/pwm-sun20i.c:343:31: error: incomplete definition of type 'struct platform_device'
343 | sun20i_chip->chip.dev = &pdev->dev;
| ~~~~^
drivers/pwm/pwm-sun20i.c:297:36: note: forward declaration of 'struct platform_device'
297 | static int sun20i_pwm_probe(struct platform_device *pdev)
| ^
drivers/pwm/pwm-sun20i.c:351:29: error: incomplete definition of type 'struct platform_device'
351 | return dev_err_probe(&pdev->dev, ret, "failed to add PWM chip\n");
| ~~~~^
drivers/pwm/pwm-sun20i.c:297:36: note: forward declaration of 'struct platform_device'
297 | static int sun20i_pwm_probe(struct platform_device *pdev)
| ^
>> drivers/pwm/pwm-sun20i.c:354:2: error: call to undeclared function 'platform_set_drvdata'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
354 | platform_set_drvdata(pdev, sun20i_chip);
| ^
drivers/pwm/pwm-sun20i.c:359:38: warning: declaration of 'struct platform_device' will not be visible outside of this function [-Wvisibility]
359 | static void sun20i_pwm_remove(struct platform_device *pdev)
| ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
8 warnings and 20 errors generated.
vim +288 drivers/pwm/pwm-sun20i.c
284
285 static const struct pwm_ops sun20i_pwm_ops = {
286 .get_state = sun20i_pwm_get_state,
287 .apply = sun20i_pwm_apply,
> 288 .owner = THIS_MODULE,
289 };
290
291 static const struct of_device_id sun20i_pwm_dt_ids[] = {
292 { .compatible = "allwinner,sun20i-d1-pwm" },
293 { },
294 };
295 MODULE_DEVICE_TABLE(of, sun20i_pwm_dt_ids);
296
> 297 static int sun20i_pwm_probe(struct platform_device *pdev)
298 {
299 struct sun20i_pwm_chip *sun20i_chip;
300 int ret;
301
> 302 sun20i_chip = devm_kzalloc(&pdev->dev, sizeof(*sun20i_chip), GFP_KERNEL);
303 if (!sun20i_chip)
304 return -ENOMEM;
305
> 306 sun20i_chip->base = devm_platform_ioremap_resource(pdev, 0);
307 if (IS_ERR(sun20i_chip->base))
308 return PTR_ERR(sun20i_chip->base);
309
310 sun20i_chip->clk_bus = devm_clk_get_enabled(&pdev->dev, "bus");
311 if (IS_ERR(sun20i_chip->clk_bus))
> 312 return dev_err_probe(&pdev->dev, PTR_ERR(sun20i_chip->clk_bus),
313 "failed to get bus clock\n");
314
315 sun20i_chip->clk_hosc = devm_clk_get_enabled(&pdev->dev, "hosc");
316 if (IS_ERR(sun20i_chip->clk_hosc))
317 return dev_err_probe(&pdev->dev, PTR_ERR(sun20i_chip->clk_hosc),
318 "failed to get hosc clock\n");
319
320 sun20i_chip->clk_apb0 = devm_clk_get_enabled(&pdev->dev, "apb0");
321 if (IS_ERR(sun20i_chip->clk_apb0))
322 return dev_err_probe(&pdev->dev, PTR_ERR(sun20i_chip->clk_apb0),
323 "failed to get apb0 clock\n");
324
325 sun20i_chip->rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
326 if (IS_ERR(sun20i_chip->rst))
327 return dev_err_probe(&pdev->dev, PTR_ERR(sun20i_chip->rst),
328 "failed to get bus reset\n");
329
330 ret = of_property_read_u32(pdev->dev.of_node, "allwinner,pwm-channels",
331 &sun20i_chip->chip.npwm);
332 if (ret)
333 sun20i_chip->chip.npwm = 8;
334
335 if (sun20i_chip->chip.npwm > 16)
336 sun20i_chip->chip.npwm = 16;
337
338 /* Deassert reset */
339 ret = reset_control_deassert(sun20i_chip->rst);
340 if (ret)
341 return dev_err_probe(&pdev->dev, ret, "failed to deassert reset\n");
342
343 sun20i_chip->chip.dev = &pdev->dev;
344 sun20i_chip->chip.ops = &sun20i_pwm_ops;
345
346 mutex_init(&sun20i_chip->mutex);
347
348 ret = pwmchip_add(&sun20i_chip->chip);
349 if (ret < 0) {
350 reset_control_assert(sun20i_chip->rst);
351 return dev_err_probe(&pdev->dev, ret, "failed to add PWM chip\n");
352 }
353
> 354 platform_set_drvdata(pdev, sun20i_chip);
355
356 return 0;
357 }
358
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the linux-arm-kernel
mailing list