[PATCH 10/15] soc: renesas: Introduce ARCH_RCAR_GEN4

Wolfram Sang wsa at kernel.org
Wed Jan 24 02:48:34 PST 2024


On Mon, Jan 08, 2024 at 04:33:49PM +0100, Geert Uytterhoeven wrote:
> Currently, all Kconfig symbols for R-Car Gen4 SoCs select the
> ARCH_RCAR_GEN3 SoC family symbol, which might confuse the casual reader.
> 
> Fix this by introducing a new SoC family symbol for R-Car Gen4 SoCs.
> For now this just selects ARCH_RCAR_GEN3, to avoid duplication, and to
> relax dependencies.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be>
> ---

Reviewed-by: Wolfram Sang <wsa+renesas at sang-engineering.com>

> Once "[PATCH] i2c: rcar: Prepare for the advent of ARCH_RCAR_GEN4"[1]
> has been applied, ARCH_RCAR_GEN4 can stop selecting ARCH_RCAR_GEN3.

Oh, that's me :)

> I'm open for suggestions how to improve this.
> Perhaps factor out common parts into ARCH_RCAR?

I kinda like the situation after this patch. I'd think using ARCH_RCAR
might hurt readability. Also, if Gen5 needs to modify ARCH_RCAR, then we
need to fix up old archs. Potential regressions ahead.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20240124/c925f492/attachment.sig>


More information about the linux-arm-kernel mailing list