[PATCH v8 4/5] iommu/arm-smmu: add ACTLR data and support for SM8550

[Bibek Kumar Patro]

On 1/18/2024 11:28 PM, Konrad Dybcio wrote:
> 
> 
> On 1/16/24 16:04, Bibek Kumar Patro wrote:
>> Add ACTLR data table for SM8550 along with support for
>> same including SM8550 specific implementation operations.
>>
>> Signed-off-by: Bibek Kumar Patro <quic_bibekkum at quicinc.com>
>> ---
> 
> [...]
> 
>> +static const struct actlr_variant sm8550_actlr[] = {
>> +    { .io_start = 0x15000000, .actlrcfg = sm8550_apps_actlr_cfg,
>> +            .num_actlrcfg = ARRAY_SIZE(sm8550_apps_actlr_cfg) },
>> +    { .io_start = 0x03da0000, .actlrcfg = sm8550_gfx_actlr_cfg,
>> +            .num_actlrcfg = ARRAY_SIZE(sm8550_gfx_actlr_cfg) },
>> +};
> Just a nit again, but if struct definitions need to be wrapped, this looks
> better:
> 
> {
>      .io_start = 0...,
>      .aclrcfg = ...,
>      .num_actlrcfg = ARR..,
> }, {
>      .io_start = 0..,
>      .aclrcfg = ...,
>      .num_actlrcfg = ARR..,
> };
> 

Noted, will wrap this to keep each member in a new line as shown.
This looks much cleaner. Thanks for this suggestion.

Regards,
Bibek

> Konrad