[PATCH 17/33] spi: bitbang: Follow renaming of SPI "master" to "controller"
kernel test robot
lkp at intel.com
Thu Jan 18 23:11:19 PST 2024
Hi Uwe,
kernel test robot noticed the following build errors:
[auto build test ERROR on 8d04a7e2ee3fd6aabb8096b00c64db0d735bc874]
url: https://github.com/intel-lab-lkp/linux/commits/Uwe-Kleine-K-nig/fpga-ice40-spi-Follow-renaming-of-SPI-master-to-controller/20240116-082610
base: 8d04a7e2ee3fd6aabb8096b00c64db0d735bc874
patch link: https://lore.kernel.org/r/95602f4f5b17eae6f3381a3153dedd0031b03aba.1705348269.git.u.kleine-koenig%40pengutronix.de
patch subject: [PATCH 17/33] spi: bitbang: Follow renaming of SPI "master" to "controller"
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20240119/202401191416.5ex4deYN-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240119/202401191416.5ex4deYN-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401191416.5ex4deYN-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/spi/spi-sh-sci.c: In function 'sh_sci_spi_probe':
>> drivers/spi/spi-sh-sci.c:139:20: error: 'struct spi_bitbang' has no member named 'master'
139 | sp->bitbang.master = host;
| ^
drivers/spi/spi-sh-sci.c:140:20: error: 'struct spi_bitbang' has no member named 'master'
140 | sp->bitbang.master->bus_num = sp->info->bus_num;
| ^
drivers/spi/spi-sh-sci.c:141:20: error: 'struct spi_bitbang' has no member named 'master'
141 | sp->bitbang.master->num_chipselect = sp->info->num_chipselect;
| ^
drivers/spi/spi-sh-sci.c:169:39: error: 'struct spi_bitbang' has no member named 'master'
169 | spi_controller_put(sp->bitbang.master);
| ^
drivers/spi/spi-sh-sci.c: In function 'sh_sci_spi_remove':
drivers/spi/spi-sh-sci.c:181:39: error: 'struct spi_bitbang' has no member named 'master'
181 | spi_controller_put(sp->bitbang.master);
| ^
vim +139 drivers/spi/spi-sh-sci.c
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 113
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 114 static int sh_sci_spi_probe(struct platform_device *dev)
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 115 {
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 116 struct resource *r;
91a940bb1075337 drivers/spi/spi-sh-sci.c Yang Yingliang 2023-08-18 117 struct spi_controller *host;
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 118 struct sh_sci_spi *sp;
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 119 int ret;
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 120
91a940bb1075337 drivers/spi/spi-sh-sci.c Yang Yingliang 2023-08-18 121 host = spi_alloc_host(&dev->dev, sizeof(struct sh_sci_spi));
91a940bb1075337 drivers/spi/spi-sh-sci.c Yang Yingliang 2023-08-18 122 if (host == NULL) {
91a940bb1075337 drivers/spi/spi-sh-sci.c Yang Yingliang 2023-08-18 123 dev_err(&dev->dev, "failed to allocate spi host\n");
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 124 ret = -ENOMEM;
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 125 goto err0;
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 126 }
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 127
91a940bb1075337 drivers/spi/spi-sh-sci.c Yang Yingliang 2023-08-18 128 sp = spi_controller_get_devdata(host);
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 129
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 130 platform_set_drvdata(dev, sp);
8074cf063e410a2 drivers/spi/spi-sh-sci.c Jingoo Han 2013-07-30 131 sp->info = dev_get_platdata(&dev->dev);
ed8eb250d7b097d drivers/spi/spi-sh-sci.c Axel Lin 2014-03-13 132 if (!sp->info) {
ed8eb250d7b097d drivers/spi/spi-sh-sci.c Axel Lin 2014-03-13 133 dev_err(&dev->dev, "platform data is missing\n");
ed8eb250d7b097d drivers/spi/spi-sh-sci.c Axel Lin 2014-03-13 134 ret = -ENOENT;
ed8eb250d7b097d drivers/spi/spi-sh-sci.c Axel Lin 2014-03-13 135 goto err1;
ed8eb250d7b097d drivers/spi/spi-sh-sci.c Axel Lin 2014-03-13 136 }
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 137
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 138 /* setup spi bitbang adaptor */
91a940bb1075337 drivers/spi/spi-sh-sci.c Yang Yingliang 2023-08-18 @139 sp->bitbang.master = host;
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 140 sp->bitbang.master->bus_num = sp->info->bus_num;
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 141 sp->bitbang.master->num_chipselect = sp->info->num_chipselect;
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 142 sp->bitbang.chipselect = sh_sci_spi_chipselect;
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 143
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 144 sp->bitbang.txrx_word[SPI_MODE_0] = sh_sci_spi_txrx_mode0;
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 145 sp->bitbang.txrx_word[SPI_MODE_1] = sh_sci_spi_txrx_mode1;
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 146 sp->bitbang.txrx_word[SPI_MODE_2] = sh_sci_spi_txrx_mode2;
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 147 sp->bitbang.txrx_word[SPI_MODE_3] = sh_sci_spi_txrx_mode3;
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 148
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 149 r = platform_get_resource(dev, IORESOURCE_MEM, 0);
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 150 if (r == NULL) {
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 151 ret = -ENOENT;
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 152 goto err1;
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 153 }
76b6fdd35a2d796 drivers/spi/spi_sh_sci.c hartleys 2009-12-14 154 sp->membase = ioremap(r->start, resource_size(r));
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 155 if (!sp->membase) {
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 156 ret = -ENXIO;
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 157 goto err1;
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 158 }
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 159 sp->val = ioread8(SCSPTR(sp));
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 160 setbits(sp, PIN_INIT, 1);
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 161
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 162 ret = spi_bitbang_start(&sp->bitbang);
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 163 if (!ret)
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 164 return 0;
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 165
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 166 setbits(sp, PIN_INIT, 0);
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 167 iounmap(sp->membase);
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 168 err1:
91a940bb1075337 drivers/spi/spi-sh-sci.c Yang Yingliang 2023-08-18 169 spi_controller_put(sp->bitbang.master);
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 170 err0:
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 171 return ret;
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 172 }
37e466408796300 drivers/spi/spi_sh_sci.c Magnus Damm 2008-02-06 173
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the linux-arm-kernel
mailing list