Aw: Re: [PATCH v3 1/2] dt-bindings: reset: mediatek: add MT7988 reset IDs

[Frank Wunderlich]

> Gesendet: Donnerstag, 18. Januar 2024 um 17:49 Uhr
> Von: "Conor Dooley" <conor at kernel.org>
> On Wed, Jan 17, 2024 at 07:41:10PM +0100, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w at public-files.de>
> >
> > Add reset constants for using as index in driver and dts.
> >
> > Signed-off-by: Frank Wunderlich <frank-w at public-files.de>
> > ---
> > v3:
> > - add pcie reset id as suggested by angelo
> >
> > v2:
> >  - add missing commit message and SoB
> >  - change value of infrareset to 0
> > ---
> >  include/dt-bindings/reset/mediatek,mt7988-resets.h | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/include/dt-bindings/reset/mediatek,mt7988-resets.h b/include/dt-bindings/reset/mediatek,mt7988-resets.h
> > index 493301971367..0eb152889a89 100644
> > --- a/include/dt-bindings/reset/mediatek,mt7988-resets.h
> > +++ b/include/dt-bindings/reset/mediatek,mt7988-resets.h
> > @@ -10,4 +10,10 @@
> >  /* ETHWARP resets */
> >  #define MT7988_ETHWARP_RST_SWITCH		0
> >
> > +/* INFRA resets */
> > +#define MT7988_INFRA_RST0_PEXTP_MAC_SWRST	0
> > +#define MT7988_INFRA_RST1_THERM_CTRL_SWRST	1
>
> These are just "random" numbers, why not continue the numbering from the
> ETHWARP?

i can do...basicly these consts are used in DTS and driver only as index.

@angelo what do you think? I though also in leaving some space to allow grouping RST0 and RST1
when more consts are added, else the numbers are mixed up.

so e.g. let RST0 start at 20 and RST1 at 40 (or even higher, because RST0 and RST1 can have up to 32 resets).
That will allow adding more reset constants between my values and having raising numbers.

regards Frank