[PATCH] tty: serial: Fix bit order in RS485 flag definitions

Greg Kroah-Hartman gregkh at linuxfoundation.org
Thu Jan 18 06:18:43 PST 2024


On Thu, Jan 18, 2024 at 01:43:50PM +0100, Christoph Niedermaier wrote:
> Since the commit 93f3350c46fa ("RS485: fix inconsistencies in the
> meaning of some variables"), the definition for bit 3 has been removed.
> But with the switch to bit shift marcos in commit 76ac8e29855b ("tty:
> serial: Cleanup the bit shift with macro"), this gap wasn't preserved.
> To avoid a break in user/kernel api of the system skip bit 3 again and
> add a placeholder comment.
> 
> Signed-off-by: Christoph Niedermaier <cniedermaier at dh-electronics.com>
> ---
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> Cc: Crescent CY Hsieh <crescentcy.hsieh at moxa.com>
> Cc: Jiri Slaby <jirislaby at kernel.org>
> Cc: Lukas Wunner <lukas at wunner.de>
> Cc: Lino Sanfilippo <l.sanfilippo at kunbus.com>
> To: linux-serial at vger.kernel.org
> To: linux-arm-kernel at lists.infradead.org
> ---

Shouldn't this have a Fixes: tag in it?

thanks,

greg k-h



More information about the linux-arm-kernel mailing list