[PATCH] firmware/arm_sdei: Fix invalid argument to unregister private events.

[Yun Levi]

Hi James, Pierre.


> > I think you can also add:
> > Fixes: d2c48b2387eb ("firmware: arm_sdei: Fix sleep from invalid context BUG")

Thanks, I'll add this fix tag.

> >> diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c
> >> index 285fe7ad490d..3e8051fe8296 100644
> >> --- a/drivers/firmware/arm_sdei.c
> >> +++ b/drivers/firmware/arm_sdei.c
> >> @@ -763,7 +763,7 @@ static int sdei_device_freeze(struct device *dev)
> >>       int err;
> >>         /* unregister private events */
> >> -    cpuhp_remove_state(sdei_entry_point);
> >> +    cpuhp_remove_state(sdei_hp_state);
> >
> > Maybe it would also be worth resetting 'sdei_hp_state':
> >   sdei_hp_state = 0;
>
> The next call should always be 'thaw', which doesn't check this, but it's good to cleanup
> stale values.
>
But, I think it should be checked on sdei_reboot_notifier.
otherwise, In the situation sdei device was freezed, when
sdei_reboot_notifier is called,
It would fail on cpuhp_cb_check too.

Should I add a sanity check on sdei_reboot_notifier in the next patch?

Many thanks!