[PATCH AUTOSEL 6.6 078/104] ARM64: dts: marvell: Fix some common switch mistakes
Sasha Levin
sashal at kernel.org
Tue Jan 16 11:46:44 PST 2024
From: Linus Walleij <linus.walleij at linaro.org>
[ Upstream commit 605a5f5d406df0c01d92e36a7b5419ffaf62a4ce ]
Fix some errors in the Marvell MV88E6xxx switch descriptions:
- The top node had no address size or cells.
- switch0 at 0 is not OK, should be ethernet-switch at 0.
- ports should be ethernet-ports
- port at 0 should be ethernet-port at 0
- PHYs should be named ethernet-phy@
Reviewed-by: Andrew Lunn <andrew at lunn.ch>
Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
Reviewed-by: Florian Fainelli <florian.fainelli at broadcom.com>
Signed-off-by: David S. Miller <davem at davemloft.net>
Signed-off-by: Sasha Levin <sashal at kernel.org>
---
.../marvell/armada-3720-espressobin-ultra.dts | 14 +--
.../dts/marvell/armada-3720-espressobin.dtsi | 20 ++---
.../dts/marvell/armada-3720-gl-mv1000.dts | 20 ++---
.../dts/marvell/armada-3720-turris-mox.dts | 85 +++++++++++--------
.../boot/dts/marvell/armada-7040-mochabin.dts | 24 +++---
.../marvell/armada-8040-clearfog-gt-8k.dts | 22 ++---
arch/arm64/boot/dts/marvell/cn9130-crb.dtsi | 42 +++++----
7 files changed, 115 insertions(+), 112 deletions(-)
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
index f9abef8dcc94..870bb380a40a 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
@@ -126,32 +126,32 @@ &switch0 {
reset-gpios = <&gpiosb 23 GPIO_ACTIVE_LOW>;
- ports {
- switch0port1: port at 1 {
+ ethernet-ports {
+ switch0port1: ethernet-port at 1 {
reg = <1>;
label = "lan0";
phy-handle = <&switch0phy0>;
};
- switch0port2: port at 2 {
+ switch0port2: ethernet-port at 2 {
reg = <2>;
label = "lan1";
phy-handle = <&switch0phy1>;
};
- switch0port3: port at 3 {
+ switch0port3: ethernet-port at 3 {
reg = <3>;
label = "lan2";
phy-handle = <&switch0phy2>;
};
- switch0port4: port at 4 {
+ switch0port4: ethernet-port at 4 {
reg = <4>;
label = "lan3";
phy-handle = <&switch0phy3>;
};
- switch0port5: port at 5 {
+ switch0port5: ethernet-port at 5 {
reg = <5>;
label = "wan";
phy-handle = <&extphy>;
@@ -160,7 +160,7 @@ switch0port5: port at 5 {
};
mdio {
- switch0phy3: switch0phy3 at 14 {
+ switch0phy3: ethernet-phy at 14 {
reg = <0x14>;
};
};
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
index 5fc613d24151..86ec0df1c676 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
@@ -145,19 +145,17 @@ &usb2 {
};
&mdio {
- switch0: switch0 at 1 {
+ switch0: ethernet-switch at 1 {
compatible = "marvell,mv88e6085";
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
dsa,member = <0 0>;
- ports {
+ ethernet-ports {
#address-cells = <1>;
#size-cells = <0>;
- switch0port0: port at 0 {
+ switch0port0: ethernet-port at 0 {
reg = <0>;
label = "cpu";
ethernet = <ð0>;
@@ -168,19 +166,19 @@ fixed-link {
};
};
- switch0port1: port at 1 {
+ switch0port1: ethernet-port at 1 {
reg = <1>;
label = "wan";
phy-handle = <&switch0phy0>;
};
- switch0port2: port at 2 {
+ switch0port2: ethernet-port at 2 {
reg = <2>;
label = "lan0";
phy-handle = <&switch0phy1>;
};
- switch0port3: port at 3 {
+ switch0port3: ethernet-port at 3 {
reg = <3>;
label = "lan1";
phy-handle = <&switch0phy2>;
@@ -192,13 +190,13 @@ mdio {
#address-cells = <1>;
#size-cells = <0>;
- switch0phy0: switch0phy0 at 11 {
+ switch0phy0: ethernet-phy at 11 {
reg = <0x11>;
};
- switch0phy1: switch0phy1 at 12 {
+ switch0phy1: ethernet-phy at 12 {
reg = <0x12>;
};
- switch0phy2: switch0phy2 at 13 {
+ switch0phy2: ethernet-phy at 13 {
reg = <0x13>;
};
};
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
index b1b45b4fa9d4..63fbc8352161 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
@@ -152,31 +152,29 @@ &uart0 {
};
&mdio {
- switch0: switch0 at 1 {
+ switch0: ethernet-switch at 1 {
compatible = "marvell,mv88e6085";
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
dsa,member = <0 0>;
- ports: ports {
+ ports: ethernet-ports {
#address-cells = <1>;
#size-cells = <0>;
- port at 0 {
+ ethernet-port at 0 {
reg = <0>;
label = "cpu";
ethernet = <ð0>;
};
- port at 1 {
+ ethernet-port at 1 {
reg = <1>;
label = "wan";
phy-handle = <&switch0phy0>;
};
- port at 2 {
+ ethernet-port at 2 {
reg = <2>;
label = "lan0";
phy-handle = <&switch0phy1>;
@@ -185,7 +183,7 @@ port at 2 {
nvmem-cell-names = "mac-address";
};
- port at 3 {
+ ethernet-port at 3 {
reg = <3>;
label = "lan1";
phy-handle = <&switch0phy2>;
@@ -199,13 +197,13 @@ mdio {
#address-cells = <1>;
#size-cells = <0>;
- switch0phy0: switch0phy0 at 11 {
+ switch0phy0: ethernet-phy at 11 {
reg = <0x11>;
};
- switch0phy1: switch0phy1 at 12 {
+ switch0phy1: ethernet-phy at 12 {
reg = <0x12>;
};
- switch0phy2: switch0phy2 at 13 {
+ switch0phy2: ethernet-phy at 13 {
reg = <0x13>;
};
};
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
index 9eab2bb22134..66cd98b67744 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
@@ -304,7 +304,13 @@ phy1: ethernet-phy at 1 {
reg = <1>;
};
- /* switch nodes are enabled by U-Boot if modules are present */
+ /*
+ * NOTE: switch nodes are enabled by U-Boot if modules are present
+ * DO NOT change this node name (switch0 at 10) even if it is not following
+ * conventions! Deployed U-Boot binaries are explicitly looking for
+ * this node in order to augment the device tree!
+ * Also do not touch the "ports" or "port at n" nodes. These are also ABI.
+ */
switch0 at 10 {
compatible = "marvell,mv88e6190";
reg = <0x10>;
@@ -317,35 +323,35 @@ mdio {
#address-cells = <1>;
#size-cells = <0>;
- switch0phy1: switch0phy1 at 1 {
+ switch0phy1: ethernet-phy at 1 {
reg = <0x1>;
};
- switch0phy2: switch0phy2 at 2 {
+ switch0phy2: ethernet-phy at 2 {
reg = <0x2>;
};
- switch0phy3: switch0phy3 at 3 {
+ switch0phy3: ethernet-phy at 3 {
reg = <0x3>;
};
- switch0phy4: switch0phy4 at 4 {
+ switch0phy4: ethernet-phy at 4 {
reg = <0x4>;
};
- switch0phy5: switch0phy5 at 5 {
+ switch0phy5: ethernet-phy at 5 {
reg = <0x5>;
};
- switch0phy6: switch0phy6 at 6 {
+ switch0phy6: ethernet-phy at 6 {
reg = <0x6>;
};
- switch0phy7: switch0phy7 at 7 {
+ switch0phy7: ethernet-phy at 7 {
reg = <0x7>;
};
- switch0phy8: switch0phy8 at 8 {
+ switch0phy8: ethernet-phy at 8 {
reg = <0x8>;
};
};
@@ -430,6 +436,7 @@ port-sfp at a {
};
};
+ /* NOTE: this node name is ABI, don't change it! */
switch0 at 2 {
compatible = "marvell,mv88e6085";
reg = <0x2>;
@@ -442,19 +449,19 @@ mdio {
#address-cells = <1>;
#size-cells = <0>;
- switch0phy1_topaz: switch0phy1 at 11 {
+ switch0phy1_topaz: ethernet-phy at 11 {
reg = <0x11>;
};
- switch0phy2_topaz: switch0phy2 at 12 {
+ switch0phy2_topaz: ethernet-phy at 12 {
reg = <0x12>;
};
- switch0phy3_topaz: switch0phy3 at 13 {
+ switch0phy3_topaz: ethernet-phy at 13 {
reg = <0x13>;
};
- switch0phy4_topaz: switch0phy4 at 14 {
+ switch0phy4_topaz: ethernet-phy at 14 {
reg = <0x14>;
};
};
@@ -497,6 +504,7 @@ port at 5 {
};
};
+ /* NOTE: this node name is ABI, don't change it! */
switch1 at 11 {
compatible = "marvell,mv88e6190";
reg = <0x11>;
@@ -509,35 +517,35 @@ mdio {
#address-cells = <1>;
#size-cells = <0>;
- switch1phy1: switch1phy1 at 1 {
+ switch1phy1: ethernet-phy at 1 {
reg = <0x1>;
};
- switch1phy2: switch1phy2 at 2 {
+ switch1phy2: ethernet-phy at 2 {
reg = <0x2>;
};
- switch1phy3: switch1phy3 at 3 {
+ switch1phy3: ethernet-phy at 3 {
reg = <0x3>;
};
- switch1phy4: switch1phy4 at 4 {
+ switch1phy4: ethernet-phy at 4 {
reg = <0x4>;
};
- switch1phy5: switch1phy5 at 5 {
+ switch1phy5: ethernet-phy at 5 {
reg = <0x5>;
};
- switch1phy6: switch1phy6 at 6 {
+ switch1phy6: ethernet-phy at 6 {
reg = <0x6>;
};
- switch1phy7: switch1phy7 at 7 {
+ switch1phy7: ethernet-phy at 7 {
reg = <0x7>;
};
- switch1phy8: switch1phy8 at 8 {
+ switch1phy8: ethernet-phy at 8 {
reg = <0x8>;
};
};
@@ -622,6 +630,7 @@ port-sfp at a {
};
};
+ /* NOTE: this node name is ABI, don't change it! */
switch1 at 2 {
compatible = "marvell,mv88e6085";
reg = <0x2>;
@@ -634,19 +643,19 @@ mdio {
#address-cells = <1>;
#size-cells = <0>;
- switch1phy1_topaz: switch1phy1 at 11 {
+ switch1phy1_topaz: ethernet-phy at 11 {
reg = <0x11>;
};
- switch1phy2_topaz: switch1phy2 at 12 {
+ switch1phy2_topaz: ethernet-phy at 12 {
reg = <0x12>;
};
- switch1phy3_topaz: switch1phy3 at 13 {
+ switch1phy3_topaz: ethernet-phy at 13 {
reg = <0x13>;
};
- switch1phy4_topaz: switch1phy4 at 14 {
+ switch1phy4_topaz: ethernet-phy at 14 {
reg = <0x14>;
};
};
@@ -689,6 +698,7 @@ port at 5 {
};
};
+ /* NOTE: this node name is ABI, don't change it! */
switch2 at 12 {
compatible = "marvell,mv88e6190";
reg = <0x12>;
@@ -701,35 +711,35 @@ mdio {
#address-cells = <1>;
#size-cells = <0>;
- switch2phy1: switch2phy1 at 1 {
+ switch2phy1: ethernet-phy at 1 {
reg = <0x1>;
};
- switch2phy2: switch2phy2 at 2 {
+ switch2phy2: ethernet-phy at 2 {
reg = <0x2>;
};
- switch2phy3: switch2phy3 at 3 {
+ switch2phy3: ethernet-phy at 3 {
reg = <0x3>;
};
- switch2phy4: switch2phy4 at 4 {
+ switch2phy4: ethernet-phy at 4 {
reg = <0x4>;
};
- switch2phy5: switch2phy5 at 5 {
+ switch2phy5: ethernet-phy at 5 {
reg = <0x5>;
};
- switch2phy6: switch2phy6 at 6 {
+ switch2phy6: ethernet-phy at 6 {
reg = <0x6>;
};
- switch2phy7: switch2phy7 at 7 {
+ switch2phy7: ethernet-phy at 7 {
reg = <0x7>;
};
- switch2phy8: switch2phy8 at 8 {
+ switch2phy8: ethernet-phy at 8 {
reg = <0x8>;
};
};
@@ -805,6 +815,7 @@ port-sfp at a {
};
};
+ /* NOTE: this node name is ABI, don't change it! */
switch2 at 2 {
compatible = "marvell,mv88e6085";
reg = <0x2>;
@@ -817,19 +828,19 @@ mdio {
#address-cells = <1>;
#size-cells = <0>;
- switch2phy1_topaz: switch2phy1 at 11 {
+ switch2phy1_topaz: ethernet-phy at 11 {
reg = <0x11>;
};
- switch2phy2_topaz: switch2phy2 at 12 {
+ switch2phy2_topaz: ethernet-phy at 12 {
reg = <0x12>;
};
- switch2phy3_topaz: switch2phy3 at 13 {
+ switch2phy3_topaz: ethernet-phy at 13 {
reg = <0x13>;
};
- switch2phy4_topaz: switch2phy4 at 14 {
+ switch2phy4_topaz: ethernet-phy at 14 {
reg = <0x14>;
};
};
diff --git a/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts b/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts
index 48202810bf78..40b7ee7ead72 100644
--- a/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts
+++ b/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts
@@ -301,10 +301,8 @@ eth2phy: ethernet-phy at 1 {
};
/* 88E6141 Topaz switch */
- switch: switch at 3 {
+ switch: ethernet-switch at 3 {
compatible = "marvell,mv88e6085";
- #address-cells = <1>;
- #size-cells = <0>;
reg = <3>;
pinctrl-names = "default";
@@ -314,35 +312,35 @@ switch: switch at 3 {
interrupt-parent = <&cp0_gpio1>;
interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
- ports {
+ ethernet-ports {
#address-cells = <1>;
#size-cells = <0>;
- swport1: port at 1 {
+ swport1: ethernet-port at 1 {
reg = <1>;
label = "lan0";
phy-handle = <&swphy1>;
};
- swport2: port at 2 {
+ swport2: ethernet-port at 2 {
reg = <2>;
label = "lan1";
phy-handle = <&swphy2>;
};
- swport3: port at 3 {
+ swport3: ethernet-port at 3 {
reg = <3>;
label = "lan2";
phy-handle = <&swphy3>;
};
- swport4: port at 4 {
+ swport4: ethernet-port at 4 {
reg = <4>;
label = "lan3";
phy-handle = <&swphy4>;
};
- port at 5 {
+ ethernet-port at 5 {
reg = <5>;
label = "cpu";
ethernet = <&cp0_eth1>;
@@ -355,19 +353,19 @@ mdio {
#address-cells = <1>;
#size-cells = <0>;
- swphy1: swphy1 at 17 {
+ swphy1: ethernet-phy at 17 {
reg = <17>;
};
- swphy2: swphy2 at 18 {
+ swphy2: ethernet-phy at 18 {
reg = <18>;
};
- swphy3: swphy3 at 19 {
+ swphy3: ethernet-phy at 19 {
reg = <19>;
};
- swphy4: swphy4 at 20 {
+ swphy4: ethernet-phy at 20 {
reg = <20>;
};
};
diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
index 4125202028c8..67892f0d2863 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
+++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
@@ -497,42 +497,42 @@ ge_phy: ethernet-phy at 0 {
reset-deassert-us = <10000>;
};
- switch0: switch0 at 4 {
+ switch0: ethernet-switch at 4 {
compatible = "marvell,mv88e6085";
reg = <4>;
pinctrl-names = "default";
pinctrl-0 = <&cp1_switch_reset_pins>;
reset-gpios = <&cp1_gpio1 24 GPIO_ACTIVE_LOW>;
- ports {
+ ethernet-ports {
#address-cells = <1>;
#size-cells = <0>;
- port at 1 {
+ ethernet-port at 1 {
reg = <1>;
label = "lan2";
phy-handle = <&switch0phy0>;
};
- port at 2 {
+ ethernet-port at 2 {
reg = <2>;
label = "lan1";
phy-handle = <&switch0phy1>;
};
- port at 3 {
+ ethernet-port at 3 {
reg = <3>;
label = "lan4";
phy-handle = <&switch0phy2>;
};
- port at 4 {
+ ethernet-port at 4 {
reg = <4>;
label = "lan3";
phy-handle = <&switch0phy3>;
};
- port at 5 {
+ ethernet-port at 5 {
reg = <5>;
label = "cpu";
ethernet = <&cp1_eth2>;
@@ -545,19 +545,19 @@ mdio {
#address-cells = <1>;
#size-cells = <0>;
- switch0phy0: switch0phy0 at 11 {
+ switch0phy0: ethernet-phy at 11 {
reg = <0x11>;
};
- switch0phy1: switch0phy1 at 12 {
+ switch0phy1: ethernet-phy at 12 {
reg = <0x12>;
};
- switch0phy2: switch0phy2 at 13 {
+ switch0phy2: ethernet-phy at 13 {
reg = <0x13>;
};
- switch0phy3: switch0phy3 at 14 {
+ switch0phy3: ethernet-phy at 14 {
reg = <0x14>;
};
};
diff --git a/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi b/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi
index 47d45ff3d6f5..6fcc34f7b464 100644
--- a/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi
+++ b/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi
@@ -207,11 +207,9 @@ phy0: ethernet-phy at 0 {
reg = <0>;
};
- switch6: switch0 at 6 {
+ switch6: ethernet-switch at 6 {
/* Actual device is MV88E6393X */
compatible = "marvell,mv88e6190";
- #address-cells = <1>;
- #size-cells = <0>;
reg = <6>;
interrupt-parent = <&cp0_gpio1>;
interrupts = <28 IRQ_TYPE_LEVEL_LOW>;
@@ -220,59 +218,59 @@ switch6: switch0 at 6 {
dsa,member = <0 0>;
- ports {
+ ethernet-ports {
#address-cells = <1>;
#size-cells = <0>;
- port at 1 {
+ ethernet-port at 1 {
reg = <1>;
label = "p1";
phy-handle = <&switch0phy1>;
};
- port at 2 {
+ ethernet-port at 2 {
reg = <2>;
label = "p2";
phy-handle = <&switch0phy2>;
};
- port at 3 {
+ ethernet-port at 3 {
reg = <3>;
label = "p3";
phy-handle = <&switch0phy3>;
};
- port at 4 {
+ ethernet-port at 4 {
reg = <4>;
label = "p4";
phy-handle = <&switch0phy4>;
};
- port at 5 {
+ ethernet-port at 5 {
reg = <5>;
label = "p5";
phy-handle = <&switch0phy5>;
};
- port at 6 {
+ ethernet-port at 6 {
reg = <6>;
label = "p6";
phy-handle = <&switch0phy6>;
};
- port at 7 {
+ ethernet-port at 7 {
reg = <7>;
label = "p7";
phy-handle = <&switch0phy7>;
};
- port at 8 {
+ ethernet-port at 8 {
reg = <8>;
label = "p8";
phy-handle = <&switch0phy8>;
};
- port at 9 {
+ ethernet-port at 9 {
reg = <9>;
label = "p9";
phy-mode = "10gbase-r";
@@ -280,7 +278,7 @@ port at 9 {
managed = "in-band-status";
};
- port at a {
+ ethernet-port at a {
reg = <10>;
ethernet = <&cp0_eth0>;
phy-mode = "10gbase-r";
@@ -293,35 +291,35 @@ mdio {
#address-cells = <1>;
#size-cells = <0>;
- switch0phy1: switch0phy1 at 1 {
+ switch0phy1: ethernet-phy at 1 {
reg = <0x1>;
};
- switch0phy2: switch0phy2 at 2 {
+ switch0phy2: ethernet-phy at 2 {
reg = <0x2>;
};
- switch0phy3: switch0phy3 at 3 {
+ switch0phy3: ethernet-phy at 3 {
reg = <0x3>;
};
- switch0phy4: switch0phy4 at 4 {
+ switch0phy4: ethernet-phy at 4 {
reg = <0x4>;
};
- switch0phy5: switch0phy5 at 5 {
+ switch0phy5: ethernet-phy at 5 {
reg = <0x5>;
};
- switch0phy6: switch0phy6 at 6 {
+ switch0phy6: ethernet-phy at 6 {
reg = <0x6>;
};
- switch0phy7: switch0phy7 at 7 {
+ switch0phy7: ethernet-phy at 7 {
reg = <0x7>;
};
- switch0phy8: switch0phy8 at 8 {
+ switch0phy8: ethernet-phy at 8 {
reg = <0x8>;
};
};
--
2.43.0
More information about the linux-arm-kernel
mailing list