[PATCH][next] net: microchip: sparx5: remove redundant store to variable clk_hz
Colin Ian King
colin.i.king at gmail.com
Tue Jan 16 08:18:47 PST 2024
The store to clk_hz is redundant since clk_hz goes out of scope on the
return. Fix this by replacing the *= operator with just * to remove
the store back to clk_hz.
Cleans up clang scan build warning:
warning: Although the value stored to 'clk_hz' is used in the enclosing
expression, the value is never actually read from 'clk_hz'
[deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king at gmail.com>
---
drivers/net/ethernet/microchip/sparx5/sparx5_sdlb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_sdlb.c b/drivers/net/ethernet/microchip/sparx5/sparx5_sdlb.c
index f5267218caeb..d8f49082dbe4 100644
--- a/drivers/net/ethernet/microchip/sparx5/sparx5_sdlb.c
+++ b/drivers/net/ethernet/microchip/sparx5/sparx5_sdlb.c
@@ -31,7 +31,7 @@ int sparx5_sdlb_clk_hz_get(struct sparx5 *sparx5)
clk_per_100ps = SPX5_CLK_PER_100PS_DEFAULT;
clk_hz = (10 * 1000 * 1000) / clk_per_100ps;
- return clk_hz *= 1000;
+ return clk_hz * 1000;
}
static int sparx5_sdlb_pup_interval_get(struct sparx5 *sparx5, u32 max_token,
--
2.39.2
More information about the linux-arm-kernel
mailing list